From 0ca6d0fb1ddbc39c8ea85bf4d7f425f6ef6ae653 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Moreno?= Date: Fri, 12 May 2023 09:57:32 +0200 Subject: [PATCH] limit error notifications in macos update service (#182269) fixes #182250 --- src/vs/platform/update/electron-main/updateService.darwin.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/vs/platform/update/electron-main/updateService.darwin.ts b/src/vs/platform/update/electron-main/updateService.darwin.ts index 8794110bd5a..3a38daa5947 100644 --- a/src/vs/platform/update/electron-main/updateService.darwin.ts +++ b/src/vs/platform/update/electron-main/updateService.darwin.ts @@ -50,8 +50,7 @@ export class DarwinUpdateService extends AbstractUpdateService { this.logService.error('UpdateService error:', err); // only show message when explicitly checking for updates - const shouldShowMessage = this.state.type === StateType.CheckingForUpdates ? this.state.explicit : true; - const message: string | undefined = shouldShowMessage ? err : undefined; + const message = (this.state.type === StateType.CheckingForUpdates && this.state.explicit) ? err : undefined; this.setState(State.Idle(UpdateType.Archive, message)); }