From 0df935dae9dcb95531a2bcd3e532f1d7d03e7b2d Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Wed, 15 Mar 2023 05:39:00 -0700 Subject: [PATCH] #176678 proper fix (#177195) --- src/vs/server/node/remoteExtensionsScanner.ts | 6 +++++- src/vs/server/node/serverEnvironmentService.ts | 2 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/vs/server/node/remoteExtensionsScanner.ts b/src/vs/server/node/remoteExtensionsScanner.ts index 3269c8b32ca..fe786a3add4 100644 --- a/src/vs/server/node/remoteExtensionsScanner.ts +++ b/src/vs/server/node/remoteExtensionsScanner.ts @@ -59,7 +59,11 @@ export class RemoteExtensionsScannerService implements IRemoteExtensionsScannerS if (extensionsToInstall) { _logService.trace('Installing extensions passed via args...'); this._whenExtensionsReady - .then(() => _extensionManagementCLI.installExtensions(this._asExtensionIdOrVSIX(extensionsToInstall), [], { isMachineScoped: !!environmentService.args['do-not-sync'], installPreReleaseVersion: !!environmentService.args['pre-release'], isApplicationScoped: environmentService.args['all-profiles'] }, !!environmentService.args['force'])) + .then(() => _extensionManagementCLI.installExtensions(this._asExtensionIdOrVSIX(extensionsToInstall), [], { + isMachineScoped: !!environmentService.args['do-not-sync'], + installPreReleaseVersion: !!environmentService.args['pre-release'], + isApplicationScoped: true // extensions installed during server startup are available to all profiles + }, !!environmentService.args['force'])) .then(() => { _logService.trace('Finished installing extensions'); }, error => { diff --git a/src/vs/server/node/serverEnvironmentService.ts b/src/vs/server/node/serverEnvironmentService.ts index bb445703339..38d70707b0d 100644 --- a/src/vs/server/node/serverEnvironmentService.ts +++ b/src/vs/server/node/serverEnvironmentService.ts @@ -65,7 +65,6 @@ export const serverOptions: OptionDescriptions> = { 'force': OPTIONS['force'], 'do-not-sync': OPTIONS['do-not-sync'], 'pre-release': OPTIONS['pre-release'], - 'all-profiles': { type: 'boolean' }, 'start-server': { type: 'boolean', cat: 'e', description: nls.localize('start-server', "Start the server when installing or uninstalling extensions. To be used in combination with 'install-extension', 'install-builtin-extension' and 'uninstall-extension'.") }, @@ -182,7 +181,6 @@ export interface ServerParsedArgs { force?: boolean; // used by install-extension 'do-not-sync'?: boolean; // used by install-extension 'pre-release'?: boolean; // used by install-extension - 'all-profiles'?: boolean; // used by install-extension 'start-server'?: boolean;