From 0eec29c2545b9a41bdcf19e77aea9c91bcc5de86 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Thu, 4 Aug 2022 15:30:59 -0700 Subject: [PATCH] Remove dom.getElementsByTagName (#157163) This was just calling document.getElementsByTagName --- src/vs/base/browser/dom.ts | 4 ---- src/vs/base/browser/ui/sash/sash.ts | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/vs/base/browser/dom.ts b/src/vs/base/browser/dom.ts index d378b5f6542..8ef36bb32ab 100644 --- a/src/vs/base/browser/dom.ts +++ b/src/vs/base/browser/dom.ts @@ -1155,10 +1155,6 @@ export function removeTabIndexAndUpdateFocus(node: HTMLElement): void { node.removeAttribute('tabindex'); } -export function getElementsByTagName(tag: string): HTMLElement[] { - return Array.prototype.slice.call(document.getElementsByTagName(tag), 0); -} - export function finalHandler(fn: (event: T) => any): (event: T) => any { return e => { e.preventDefault(); diff --git a/src/vs/base/browser/ui/sash/sash.ts b/src/vs/base/browser/ui/sash/sash.ts index 80ab505126e..4bc8ff1b8ee 100644 --- a/src/vs/base/browser/ui/sash/sash.ts +++ b/src/vs/base/browser/ui/sash/sash.ts @@ -3,7 +3,7 @@ * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ -import { $, append, createStyleSheet, EventHelper, EventLike, getElementsByTagName } from 'vs/base/browser/dom'; +import { $, append, createStyleSheet, EventHelper, EventLike } from 'vs/base/browser/dom'; import { DomEmitter } from 'vs/base/browser/event'; import { EventType, Gesture, GestureEvent } from 'vs/base/browser/touch'; import { Delayer } from 'vs/base/common/async'; @@ -493,7 +493,7 @@ export class Sash extends Disposable { return; } - const iframes = getElementsByTagName('iframe'); + const iframes = document.getElementsByTagName('iframe'); for (const iframe of iframes) { iframe.classList.add(PointerEventsDisabledCssClass); // disable mouse events on iframes as long as we drag the sash }