From 11f2d7e8aaef6d1bfaea51e80b207c04a957a6cd Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Wed, 28 Oct 2020 11:19:15 +0100 Subject: [PATCH] fix placement issues with details left and new padding, https://github.com/microsoft/vscode/issues/109447 also fixes an issue with forgotten custom sizes --- src/vs/editor/contrib/suggest/suggestWidgetDetails.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/vs/editor/contrib/suggest/suggestWidgetDetails.ts b/src/vs/editor/contrib/suggest/suggestWidgetDetails.ts index 20014ff8e7a..25b27062b6b 100644 --- a/src/vs/editor/contrib/suggest/suggestWidgetDetails.ts +++ b/src/vs/editor/contrib/suggest/suggestWidgetDetails.ts @@ -300,6 +300,7 @@ export class SuggestDetailsOverlay implements IOverlayWidget { sizeNow = undefined; deltaTop = 0; deltaLeft = 0; + this._userSize = e.dimension; } })); @@ -381,10 +382,10 @@ export class SuggestDetailsOverlay implements IOverlayWidget { // position: east, WEST, south if (anchorBox.left > width) { // pos = SuggestDetailsPosition.West; - width = anchorBox.left - info.borderWidth - info.horizontalPadding; + width = anchorBox.left - info.borderWidth; alignEast = false; - left = Math.max(0, anchorBox.left - (size.width + info.borderWidth)); - maxSizeTop = maxSizeTop.with(width); + left = Math.max(info.horizontalPadding, anchorBox.left - width); + maxSizeTop = maxSizeTop.with(anchorBox.left - info.horizontalPadding - info.borderWidth); maxSizeBottom = maxSizeTop.with(undefined, maxSizeBottom.height); }