From 324c3e7eea4d22d15904d10b43f6f958bfbeff93 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Mon, 8 Aug 2022 09:59:33 -0700 Subject: [PATCH] Use %s to format % chars instead of sed to sanitize Fixes #157524 --- .../contrib/terminal/browser/media/shellIntegration-bash.sh | 3 +-- .../contrib/terminal/browser/media/shellIntegration-rc.zsh | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/vs/workbench/contrib/terminal/browser/media/shellIntegration-bash.sh b/src/vs/workbench/contrib/terminal/browser/media/shellIntegration-bash.sh index 0d9d6734655..06b08cbc313 100755 --- a/src/vs/workbench/contrib/terminal/browser/media/shellIntegration-bash.sh +++ b/src/vs/workbench/contrib/terminal/browser/media/shellIntegration-bash.sh @@ -59,8 +59,7 @@ __vsc_update_cwd() { __vsc_command_output_start() { builtin printf "\033]633;C\007" - # Send command line, escaping printf format chars % - builtin printf "\033]633;E;$(echo $__vsc_current_command | sed s/%/%%/g)\007" + builtin printf "\033]633;E;%s\007" "$__vsc_current_command" } __vsc_continuation_start() { diff --git a/src/vs/workbench/contrib/terminal/browser/media/shellIntegration-rc.zsh b/src/vs/workbench/contrib/terminal/browser/media/shellIntegration-rc.zsh index 197604701a0..640d58f8725 100644 --- a/src/vs/workbench/contrib/terminal/browser/media/shellIntegration-rc.zsh +++ b/src/vs/workbench/contrib/terminal/browser/media/shellIntegration-rc.zsh @@ -51,7 +51,7 @@ __vsc_update_cwd() { __vsc_command_output_start() { builtin printf "\033]633;C\007" # Send command line, escaping printf format chars % - builtin printf "\033]633;E;$(echo $__vsc_current_command | sed s/%/%%/g)\007" + builtin printf "\033]633;E;%s\007" "$__vsc_current_command" } __vsc_continuation_start() {