telemetry - add logging for resolving IDs (#260269) (#262085)

This commit is contained in:
Benjamin Pasero
2025-08-18 07:12:08 +02:00
committed by GitHub
parent ea1973f768
commit 17b6af0ff4
7 changed files with 27 additions and 24 deletions

View File

@@ -101,7 +101,7 @@ import { ExtensionsScannerService } from '../../platform/extensionManagement/nod
import { UserDataProfilesHandler } from '../../platform/userDataProfile/electron-main/userDataProfilesHandler.js';
import { ProfileStorageChangesListenerChannel } from '../../platform/userDataProfile/electron-main/userDataProfileStorageIpc.js';
import { Promises, RunOnceScheduler, runWhenGlobalIdle } from '../../base/common/async.js';
import { resolveMachineId, resolveSqmId, resolvedevDeviceId, validatedevDeviceId } from '../../platform/telemetry/electron-main/telemetryUtils.js';
import { resolveMachineId, resolveSqmId, resolveDevDeviceId, validateDevDeviceId } from '../../platform/telemetry/electron-main/telemetryUtils.js';
import { ExtensionsProfileScannerService } from '../../platform/extensionManagement/node/extensionsProfileScannerService.js';
import { LoggerChannel } from '../../platform/log/electron-main/logIpc.js';
import { ILoggerMainService } from '../../platform/log/electron-main/loggerService.js';
@@ -565,13 +565,11 @@ export class CodeApplication extends Disposable {
});
// Resolve unique machine ID
this.logService.trace('Resolving machine identifier...');
const [machineId, sqmId, devDeviceId] = await Promise.all([
resolveMachineId(this.stateService, this.logService),
resolveSqmId(this.stateService, this.logService),
resolvedevDeviceId(this.stateService, this.logService)
resolveDevDeviceId(this.stateService, this.logService)
]);
this.logService.trace(`Resolved machine identifier: ${machineId}`);
// Shared process
const { sharedProcessReady, sharedProcessClient } = this.setupSharedProcess(machineId, sqmId, devDeviceId);
@@ -1469,6 +1467,6 @@ export class CodeApplication extends Disposable {
// Validate Device ID is up to date (delay this as it has shown significant perf impact)
// Refs: https://github.com/microsoft/vscode/issues/234064
validatedevDeviceId(this.stateService, this.logService);
validateDevDeviceId(this.stateService, this.logService);
}
}