Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 18:49:00 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make sure we dispose of event emitters properly

Browse Source
This commit is contained in:
Matt Bierner
2019-02-05 18:10:16 -08:00
parent 6b8b1b7bea
commit 198e6a55e7
3 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
extensions/markdown-language-features/src/markdownExtensions.ts
View File

@@ -118,6 +118,8 @@ export interface MarkdownContributionProvider {
readonly extensionPath: string;
readonly contributions: MarkdownContributions;
readonly onContributionsChanged: vscode.Event<this>;
dispose(): void;
}
class VSCodeExtensionMarkdownContributionProvider extends Disposable implements MarkdownContributionProvider {
@@ -138,7 +140,7 @@ class VSCodeExtensionMarkdownContributionProvider extends Disposable implements
}, undefined, this._disposables);
}
private readonly _onContributionsChanged = new vscode.EventEmitter<this>();
private readonly _onContributionsChanged = this._register(new vscode.EventEmitter<this>());
public readonly onContributionsChanged = this._onContributionsChanged.event;
public get contributions(): MarkdownContributions {