From 1a1b76f0ee5a2bd062fcb0baaade77044494ab96 Mon Sep 17 00:00:00 2001 From: Alex Ross Date: Wed, 17 Jun 2020 11:41:28 +0200 Subject: [PATCH] Check for undefined specifically in task execution test Part of #100361 --- .../singlefolder-tests/workspace.tasks.test.ts | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/extensions/vscode-api-tests/src/singlefolder-tests/workspace.tasks.test.ts b/extensions/vscode-api-tests/src/singlefolder-tests/workspace.tasks.test.ts index cb8c0ee6a50..e6347f90c2a 100644 --- a/extensions/vscode-api-tests/src/singlefolder-tests/workspace.tasks.test.ts +++ b/extensions/vscode-api-tests/src/singlefolder-tests/workspace.tasks.test.ts @@ -144,13 +144,17 @@ import { window, tasks, Disposable, TaskDefinition, Task, EventEmitter, CustomEx let taskExecution: TaskExecution | undefined; disposables.push(tasks.onDidStartTaskProcess(e => { - if (e.execution !== taskExecution) { + if (taskExecution === undefined) { + reject('taskExecution is still undefined when process started.'); + } else if (e.execution !== taskExecution) { reject('Unexpected task execution value in start process.'); } })); disposables.push(tasks.onDidEndTaskProcess(e => { - if (e.execution === taskExecution) { + if (taskExecution === undefined) { + reject('taskExecution is still undefined when process ended.'); + } else if (e.execution === taskExecution) { resolve(); } else { reject('Unexpected task execution value in end process.'); @@ -167,7 +171,9 @@ import { window, tasks, Disposable, TaskDefinition, Task, EventEmitter, CustomEx let taskExecution: TaskExecution | undefined; disposables.push(tasks.onDidStartTaskProcess(e => { - if (e.execution === taskExecution) { + if (taskExecution === undefined) { + reject('taskExecution is still undefined when process started.'); + } else if (e.execution === taskExecution) { resolve(); } else { reject('Unexpected task execution value in start process.'); @@ -175,7 +181,9 @@ import { window, tasks, Disposable, TaskDefinition, Task, EventEmitter, CustomEx })); disposables.push(tasks.onDidEndTaskProcess(e => { - if (e.execution !== taskExecution) { + if (taskExecution === undefined) { + reject('taskExecution is still undefined when process ended.'); + } else if (e.execution !== taskExecution) { reject('Unexpected task execution value in end process.'); } }));