From 1abefb9be2a9e33a78f4e9bacda722095d342a23 Mon Sep 17 00:00:00 2001 From: Alexandru Dima Date: Wed, 16 Dec 2020 13:54:06 +0100 Subject: [PATCH] Fixes #112652: A disposed IPC channel should reject all requests with a canceled error, not resolve them --- src/vs/base/parts/ipc/common/ipc.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vs/base/parts/ipc/common/ipc.ts b/src/vs/base/parts/ipc/common/ipc.ts index b459b90de71..535502f3efd 100644 --- a/src/vs/base/parts/ipc/common/ipc.ts +++ b/src/vs/base/parts/ipc/common/ipc.ts @@ -527,13 +527,13 @@ export class ChannelClient implements IChannelClient, IDisposable { return { call(command: string, arg?: any, cancellationToken?: CancellationToken) { if (that.isDisposed) { - return Promise.resolve(errors.canceled()); + return Promise.reject(errors.canceled()); } return that.requestPromise(channelName, command, arg, cancellationToken); }, listen(event: string, arg: any) { if (that.isDisposed) { - return Promise.resolve(errors.canceled()); + return Promise.reject(errors.canceled()); } return that.requestEvent(channelName, event, arg); }