Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-25 19:18:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use actual set for SupportedCodeActionProvider

Browse Source
This commit is contained in:
Matt Bierner
2018-01-04 11:19:06 -08:00
parent 5a2a6c1e2e
commit 1b847dc693
1 changed files with 4 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
extensions/typescript/src/features/quickFixProvider.ts
View File

@@ -12,10 +12,6 @@ import FormattingConfigurationManager from './formattingConfigurationManager';
import { getEditForCodeAction, applyCodeActionCommands } from '../utils/codeAction';
import { Command, CommandManager } from '../utils/commandManager';
interface NumberSet {
[key: number]: boolean;
}
class ApplyCodeActionCommand implements Command {
public static readonly ID = '_typescript.applyCodeActionCommand';
public readonly id = ApplyCodeActionCommand.ID;
@@ -32,7 +28,7 @@ class ApplyCodeActionCommand implements Command {
}
class SupportedCodeActionProvider {
private _supportedCodeActions?: Thenable<NumberSet>;
private _supportedCodeActions?: Thenable<Set<number>>;
public constructor(
private readonly client: ITypeScriptServiceClient
@@ -42,19 +38,15 @@ class SupportedCodeActionProvider {
const supportedActions = await this.supportedCodeActions;
return new Set(context.diagnostics
.map(diagnostic => +diagnostic.code)
.filter(code => supportedActions[code]));
.filter(code => supportedActions.has(code)));
}
private get supportedCodeActions(): Thenable<NumberSet> {
private get supportedCodeActions(): Thenable<Set<number>> {
if (!this._supportedCodeActions) {
this._supportedCodeActions = this.client.execute('getSupportedCodeFixes', null, undefined)
.then(response => response.body || [])
.then(codes => codes.map(code => +code).filter(code => !isNaN(code)))
.then(codes =>
codes.reduce((obj, code) => {
obj[code] = true;
return obj;
}, Object.create(null)));
.then(codes => new Set(codes));
}
return this._supportedCodeActions;
}