From 1bef9adeb620e30df377b5117db38fb9dd8dbbc7 Mon Sep 17 00:00:00 2001 From: isidor Date: Tue, 26 Jan 2016 17:58:27 +0100 Subject: [PATCH] vscode.d.ts - deprecate the whole method, not the argument fixes #2337 --- src/vs/vscode.d.ts | 11 ++++++++++- src/vs/workbench/api/node/extHostOutputService.ts | 6 +++++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/vs/vscode.d.ts b/src/vs/vscode.d.ts index 6c4b89731b9..e6efc70fb87 100644 --- a/src/vs/vscode.d.ts +++ b/src/vs/vscode.d.ts @@ -2469,11 +2469,20 @@ declare namespace vscode { /** * Reveal this channel in the UI. - * @param column @deprecated **This argument is deprecated.** The column in which to show the channel, default in [one](#ViewColumn.One). + * @deprecated **This method is deprecated.** + * + * @param column The column in which to show the channel, default in [one](#ViewColumn.One). * @param preserveFocus When `true` the channel will not take focus. */ show(column?: ViewColumn, preserveFocus?: boolean): void; + /** + * Reveal this channel in the UI. + * + * @param preserveFocus When `true` the channel will not take focus. + */ + show(preservceFocus?: boolean): void; + /** * Hide this channel from the UI. */ diff --git a/src/vs/workbench/api/node/extHostOutputService.ts b/src/vs/workbench/api/node/extHostOutputService.ts index 6712976624d..2d768b4186b 100644 --- a/src/vs/workbench/api/node/extHostOutputService.ts +++ b/src/vs/workbench/api/node/extHostOutputService.ts @@ -47,7 +47,11 @@ export class ExtHostOutputChannel implements vscode.OutputChannel { this._proxy.clear(this._name); } - show(column?: vscode.ViewColumn, preserveFocus?: boolean): void { + show(columnOrPreserveFocus?: vscode.ViewColumn | boolean, preserveFocus?: boolean): void { + if (typeof columnOrPreserveFocus === 'boolean') { + preserveFocus = columnOrPreserveFocus; + } + this._proxy.reveal(this._name, preserveFocus); }