From 1e446dfadf588ec28b3fdba7ac083bfa1d45df3c Mon Sep 17 00:00:00 2001 From: Alex Dima Date: Mon, 31 May 2021 23:08:00 +0200 Subject: [PATCH] Don't hide suggest widget when expanding ghost text --- src/vs/editor/contrib/inlineCompletions/ghostTextWidget.ts | 2 +- .../contrib/inlineCompletions/suggestWidgetAdapterModel.ts | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/vs/editor/contrib/inlineCompletions/ghostTextWidget.ts b/src/vs/editor/contrib/inlineCompletions/ghostTextWidget.ts index 1ed2aa9ed06..31b16107d49 100644 --- a/src/vs/editor/contrib/inlineCompletions/ghostTextWidget.ts +++ b/src/vs/editor/contrib/inlineCompletions/ghostTextWidget.ts @@ -258,7 +258,7 @@ export class GhostTextWidget extends Disposable { button.className = 'button suggest-preview-text'; button.append(`+${remainingLinesLength} lines…`); - disposableStore.add(dom.addStandardDisposableListener(button, 'click', (e) => { + disposableStore.add(dom.addStandardDisposableListener(button, 'mousedown', (e) => { this.model?.setExpanded(true); e.preventDefault(); this.editor.focus(); diff --git a/src/vs/editor/contrib/inlineCompletions/suggestWidgetAdapterModel.ts b/src/vs/editor/contrib/inlineCompletions/suggestWidgetAdapterModel.ts index bd7cb993c5a..75a7c065350 100644 --- a/src/vs/editor/contrib/inlineCompletions/suggestWidgetAdapterModel.ts +++ b/src/vs/editor/contrib/inlineCompletions/suggestWidgetAdapterModel.ts @@ -68,6 +68,11 @@ export class SuggestWidgetAdapterModel extends BaseGhostTextWidgetModel { })); } + public override setExpanded(expanded: boolean): void { + super.setExpanded(expanded); + this.updateFromSuggestion(); + } + private isSuggestionPreviewEnabled(): boolean { const suggestOptions = this.editor.getOption(EditorOption.suggest); return suggestOptions.showSuggestionPreview;