Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 02:28:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

Adding workaround for TS trying to update paths on file without exports

Browse Source 
Fixes #52967
This commit is contained in:
Matt Bierner
2018-06-29 17:30:53 -07:00
parent 2f0b9394bc
commit 1ee1759e02
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
extensions/typescript-language-features/src/features/updatePathsOnRename.ts
View File

@@ -83,6 +83,16 @@ export class UpdateImportsOnFileRenameHandler {
this.client.bufferSyncSupport.closeResource(targetResource);
this.client.bufferSyncSupport.openTextDocument(document);
// Workaround for https://github.com/Microsoft/vscode/issues/52967
// Never attempt to update import paths if the file does not contain something the looks like an export
const tree = await this.client.execute('navtree', { file: newFile });
const hasExport = (node: Proto.NavigationTree): boolean => {
return !!node.kindModifiers.match(/\bexport\b/g) || !!(node.childItems && node.childItems.some(hasExport));
};
if (!tree.body || !tree.body || !hasExport(tree.body)) {
return;
}
const edits = await this.getEditsForFileRename(targetFile, document, oldFile, newFile);
if (!edits || !edits.size) {
return;
@@ -201,7 +211,7 @@ export class UpdateImportsOnFileRenameHandler {
return files[0];
}
return this._handles(resource) ? resource : undefined;
return (await this._handles(resource)) ? resource : undefined;
}
private async getEditsForFileRename(