Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-06-09 00:56:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: memory leak in LoggerChannel (#315875)

Browse Source
This commit is contained in:
Simon Siefke
2026-05-21 07:03:50 +02:00
committed by GitHub
parent e4cb08595b
commit 1fc96f74c5
2 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/code/electron-main/app.ts
+1 -1
View File
@@ -1373,7 +1373,7 @@ export class CodeApplication extends Disposable {
mainProcessElectronServer.registerChannel(McpGatewayChannelName, mcpGatewayChannel);
// Logger
const loggerChannel = new LoggerChannel(accessor.get(ILoggerMainService),);
const loggerChannel = this._register(new LoggerChannel(accessor.get(ILoggerMainService)));
mainProcessElectronServer.registerChannel('logger', loggerChannel);
sharedProcessClient.then(client => client.registerChannel('logger', loggerChannel));
src/vs/platform/log/electron-main/logIpc.ts
+10 -2
View File
@@ -4,17 +4,25 @@
*--------------------------------------------------------------------------------------------*/
import { Event } from '../../../base/common/event.js';
import { Disposable } from '../../../base/common/lifecycle.js';
import { ResourceMap } from '../../../base/common/map.js';
import { URI } from '../../../base/common/uri.js';
import { IServerChannel } from '../../../base/parts/ipc/common/ipc.js';
import { ILogger, ILoggerOptions, isLogLevel, log, LogLevel } from '../common/log.js';
import { ILoggerMainService } from './loggerService.js';
export class LoggerChannel implements IServerChannel {
export class LoggerChannel extends Disposable implements IServerChannel {
private readonly loggers = new ResourceMap<ILogger>();
constructor(private readonly loggerService: ILoggerMainService) { }
constructor(private readonly loggerService: ILoggerMainService) {
super();
this._register(this.loggerService.onDidChangeLoggers(({ removed }) => {
for (const loggerResource of removed) {
this.loggers.delete(loggerResource.resource);
}
}));
}
listen(_: unknown, event: string, windowId?: number): Event<any> {
switch (event) {