From 2122d7e0bf3ef84e8525f8deeb8df6eacede95ee Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Mon, 3 Dec 2018 12:41:58 +0100 Subject: [PATCH] Remove support for post install --- .../node/extensionLifecycle.ts | 21 +------------------ 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/src/vs/platform/extensionManagement/node/extensionLifecycle.ts b/src/vs/platform/extensionManagement/node/extensionLifecycle.ts index e427d7d2403..5a641a0ae54 100644 --- a/src/vs/platform/extensionManagement/node/extensionLifecycle.ts +++ b/src/vs/platform/extensionManagement/node/extensionLifecycle.ts @@ -11,7 +11,6 @@ import { toErrorMessage } from 'vs/base/common/errorMessage'; import { posix } from 'path'; import { Limiter } from 'vs/base/common/async'; import { fromNodeEventEmitter, anyEvent, mapEvent, debounceEvent } from 'vs/base/common/event'; -import * as objects from 'vs/base/common/objects'; import { Schemas } from 'vs/base/common/network'; import { IEnvironmentService } from 'vs/platform/environment/common/environment'; import { rimraf } from 'vs/base/node/pfs'; @@ -38,21 +37,6 @@ export class ExtensionsLifecycle extends Disposable { return rimraf(this.getExtensionStoragePath(extension)).then(null, e => this.logService.error('Error while removing extension storage path', e)); } - postInstall(extension: ILocalExtension): Thenable { - const script = this.parseScript(extension, 'install'); - if (script) { - this.logService.info(extension.identifier.id, `Running post install script`); - return this.processesLimiter.queue(() => - this.runLifecycleHook(script.script, 'install', script.args, false, extension) - .then(() => this.logService.info(extension.identifier.id, `Finished running post install script`), - err => { - this.logService.error(extension.identifier.id, `Failed to run post install script: ${err}`); - return Promise.reject(err); - })); - } - return Promise.resolve(); - } - private parseScript(extension: ILocalExtension, type: string): { script: string, args: string[] } | null { const scriptKey = `vscode:${type}`; if (extension.location.scheme === Schemas.file && extension.manifest && extension.manifest['scripts'] && typeof extension.manifest['scripts'][scriptKey] === 'string') { @@ -108,10 +92,7 @@ export class ExtensionsLifecycle extends Disposable { private start(uninstallHook: string, lifecycleType: string, args: string[], extension: ILocalExtension): ChildProcess { const opts = { silent: true, - execArgv: undefined, - env: objects.mixin(objects.deepClone(process.env), { - VSCODE_EXTENSION_STORAGE_LOCATION: this.getExtensionStoragePath(extension) - }) + execArgv: undefined }; const extensionUninstallProcess = fork(uninstallHook, [`--type=extension-post-${lifecycleType}`, ...args], opts);