Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-20 00:28:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

use APIs over commands, fixes (?) https://github.com/microsoft/vscode/issues/119437

Browse Source
This commit is contained in:
Johannes Rieken
2021-03-23 09:29:24 +01:00
committed by Rob Lourens
parent bd2402a6e8
commit 22212f5de8
1 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
extensions/vscode-api-tests/src/singlefolder-tests/notebook.test.ts
View File

@@ -1249,24 +1249,25 @@ suite('Notebook API tests', function () {
});
test('#115855 onDidSaveNotebookDocument', async function () {
const resource = await createRandomFile('', undefined, '.vsctestnb');
await vscode.commands.executeCommand('vscode.openWith', resource, 'notebookCoreTest');
const resource = await createRandomFile(undefined, undefined, '.vsctestnb');
const notebook = await vscode.notebook.openNotebookDocument(resource);
const editor = await vscode.window.showNotebookDocument(notebook);
const cellsChangeEvent = asPromise<vscode.NotebookCellsChangeEvent>(vscode.notebook.onDidChangeNotebookCells);
await vscode.window.activeNotebookEditor!.edit(editBuilder => {
await editor.edit(editBuilder => {
editBuilder.replaceCells(1, 0, [{ kind: vscode.NotebookCellKind.Code, language: 'javascript', source: 'test 2', outputs: [], metadata: undefined }]);
});
const cellChangeEventRet = await cellsChangeEvent;
assert.strictEqual(cellChangeEventRet.document === vscode.window.activeNotebookEditor?.document, true);
assert.strictEqual(cellChangeEventRet.document === notebook, true);
assert.strictEqual(cellChangeEventRet.document.isDirty, true);
await withEvent(vscode.notebook.onDidSaveNotebookDocument, async event => {
await vscode.commands.executeCommand('workbench.action.files.saveAll');
await event;
assert.strictEqual(cellChangeEventRet.document.isDirty, false);
});
await saveAllFilesAndCloseAll(resource);
const saveEvent = asPromise(vscode.notebook.onDidSaveNotebookDocument);
await notebook.save();
await saveEvent;
assert.strictEqual(notebook.isDirty, false);
});
test('#116808, active kernel should not be undefined', async function () {