From 22e27fed75eaa168bc8a10bd91c5bfb60ab1f869 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Tue, 18 Oct 2016 13:58:47 -0700 Subject: [PATCH] Add null check Fixes #13865 --- .../parts/terminal/electron-browser/terminalActions.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/parts/terminal/electron-browser/terminalActions.ts b/src/vs/workbench/parts/terminal/electron-browser/terminalActions.ts index db367583fb2..59184ab75c9 100644 --- a/src/vs/workbench/parts/terminal/electron-browser/terminalActions.ts +++ b/src/vs/workbench/parts/terminal/electron-browser/terminalActions.ts @@ -225,7 +225,10 @@ export class SwitchTerminalInstanceAction extends Action { } public run(item?: string): TPromise { - let selectedTerminalIndex = parseInt(item.split(':')[0], 10) - 1; + if (!item) { + return TPromise.as(null); + } + const selectedTerminalIndex = parseInt(item.split(':')[0], 10) - 1; this.terminalService.setActiveInstanceByIndex(selectedTerminalIndex); return this.terminalService.showPanel(true); }