From 2372a22ba1cd2782756ebee74e07a37a5738084a Mon Sep 17 00:00:00 2001 From: Isidor Date: Fri, 20 Mar 2026 20:27:44 +0100 Subject: [PATCH] fixes #303425 --- .../chatAgentTools/browser/tools/runInTerminalTool.ts | 6 +----- .../test/electron-browser/runInTerminalTool.test.ts | 7 +------ 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts b/src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts index a7f21d62662..f4db29e2a73 100644 --- a/src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts +++ b/src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts @@ -720,12 +720,8 @@ export class RunInTerminalTool extends Disposable implements IToolImpl { } if (requiresUnsandboxConfirmation) { - disclaimer = new MarkdownString([ - disclaimer?.value, - localize('runInTerminal.unsandboxed.disclaimer', "$(warning) This command will run outside the terminal sandbox and may access files, network resources, or system state that sandboxed commands cannot reach.") - ].filter(Boolean).join(' '), { supportThemeIcons: true, isTrusted: disclaimer?.isTrusted }); confirmationTitle = args.isBackground - ? localize('runInTerminal.unsandboxed.background', "Run `{0}` command outside the sandbox in background?", shellType) + ? localize('runInTerminal.unsandboxed.background', "Run `{0}` background command outside the sandbox?", shellType) : localize('runInTerminal.unsandboxed', "Run `{0}` command outside the sandbox?", shellType); } diff --git a/src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/electron-browser/runInTerminalTool.test.ts b/src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/electron-browser/runInTerminalTool.test.ts index eafc29f9891..db841082d00 100644 --- a/src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/electron-browser/runInTerminalTool.test.ts +++ b/src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/electron-browser/runInTerminalTool.test.ts @@ -480,12 +480,7 @@ suite('RunInTerminalTool', () => { } ok(confirmationMessage.value.includes('Reason for leaving the sandbox: Needs network access outside the sandbox')); - const disclaimer = result?.confirmationMessages?.disclaimer; - ok(disclaimer && typeof disclaimer !== 'string'); - if (!disclaimer || typeof disclaimer === 'string') { - throw new Error('Expected markdown disclaimer'); - } - ok(disclaimer.value.includes('outside the terminal sandbox')); + strictEqual(result?.confirmationMessages?.disclaimer, undefined); strictEqual(result?.confirmationMessages?.terminalCustomActions, undefined); }); });