Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-02 00:09:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Enable test/test-integration scripts to take file.test.ts arguments (#306039)

Browse Source 
* Enable test/test-integration scripts to take file.test.ts arguments
The agent likes to use them this way, when it doesn't read the skill

Co-authored-by: Copilot <copilot@github.com>

* And this

* Fixes

* update

Co-authored-by: Copilot <copilot@github.com>

---------

Co-authored-by: Copilot <copilot@github.com>
This commit is contained in:
Rob Lourens
2026-03-28 19:48:59 -07:00
committed by GitHub
parent 73b0fb2937
commit 23c0b41d69
2 changed files with 34 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
.github/skills/unit-tests/SKILL.md vendored
View File

@@ -26,7 +26,25 @@ These scripts download Electron if needed and launch the Mocha test runner.
### Commonly used options ### Commonly used options
#### `--run <file>` - Run tests from a specific file #### Bare file paths - Run tests from specific files
Pass source file paths directly as positional arguments. The test runner automatically treats bare `.ts`/`.js` positional arguments as `--run` values.
```bash
./scripts/test.sh src/vs/editor/test/common/model.test.ts
```
```bat
.\scripts\test.bat src\vs\editor\test\common\model.test.ts
```
Multiple files:
```bash
./scripts/test.sh src/vs/editor/test/common/model.test.ts src/vs/editor/test/common/range.test.ts
```
#### `--run <file>` - Run tests from a specific file (explicit form)
Accepts a **source file path** (starting with `src/`). The runner strips the `src/` prefix and the `.ts`/`.js` extension automatically to resolve the compiled module. Accepts a **source file path** (starting with `src/`). The runner strips the `src/` prefix and the `.ts`/`.js` extension automatically to resolve the compiled module.
@@ -80,7 +98,7 @@ Override the default Mocha timeout for long-running tests.
### Integration tests ### Integration tests
Integration tests (files ending in `.integrationTest.ts` or located in `extensions/`) are **not run** by `scripts/test.sh`. Use `scripts/test-integration.sh` (or `scripts/test-integration.bat`) instead. See the `integration-tests` skill for details on filtering and running specific integration test files. Integration tests (files ending in `.integrationTest.ts` or located in `extensions/`) are **not run** by `scripts/test.sh`. Use `scripts/test-integration.sh` (or `scripts/test-integration.bat`) instead. See the `integration-tests` skill for details.
### Compilation requirement ### Compilation requirement

16
test/unit/electron/index.js
View File

@@ -27,8 +27,9 @@ const minimist = require('minimist');
/** /**
* @type {{ * @type {{
* _: string[];
* grep: string; * grep: string;
* run: string; * run: string | string[];
* runGlob: string; * runGlob: string;
* testSplit: string; * testSplit: string;
* dev: boolean; * dev: boolean;
@@ -62,7 +63,10 @@ const args = minimist(process.argv.slice(2), {
}); });
if (args.help) { if (args.help) {
console.log(`Usage: node ${process.argv[1]} [options] console.log(`Usage: node ${process.argv[1]} [options] [file...]
Bare .ts/.js file paths passed as positional arguments are treated as
--run arguments.
Options: Options:
--grep, -g, -f <pattern> only run tests matching <pattern> --grep, -g, -f <pattern> only run tests matching <pattern>
@@ -83,6 +87,14 @@ Options:
process.exit(0); process.exit(0);
} }
// Treat bare .ts/.js positional arguments as --run values
const bareFiles = (args._ || []).filter(a => typeof a === 'string' && (a.endsWith('.ts') || a.endsWith('.js')));
if (bareFiles.length > 0) {
const existing = !args.run ? [] : Array.isArray(args.run) ? args.run : [args.run];
args.run = [...existing, ...bareFiles];
args._ = (args._ || []).filter(a => !bareFiles.includes(a));
}
let crashReporterDirectory = args['crash-reporter-directory']; let crashReporterDirectory = args['crash-reporter-directory'];
if (crashReporterDirectory) { if (crashReporterDirectory) {
crashReporterDirectory = path.normalize(crashReporterDirectory); crashReporterDirectory = path.normalize(crashReporterDirectory);