From 245b24a9587a7f9ee448cd33fb94e269fe1d17aa Mon Sep 17 00:00:00 2001 From: Megan Rogge Date: Thu, 6 Feb 2025 18:11:16 -0600 Subject: [PATCH] do not deal with single tab in disposable (#239865) --- src/vs/workbench/contrib/terminal/browser/terminalView.ts | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/vs/workbench/contrib/terminal/browser/terminalView.ts b/src/vs/workbench/contrib/terminal/browser/terminalView.ts index b38deec3354..827016295cd 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalView.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalView.ts @@ -55,7 +55,6 @@ import { MicrotaskDelay } from '../../../../base/common/symbols.js'; export class TerminalViewPane extends ViewPane { private _parentDomElement: HTMLElement | undefined; private _terminalTabbedView?: TerminalTabbedView; - private readonly _singleTabActionViewItem: MutableDisposable = this._register(new MutableDisposable()); get terminalTabbedView(): TerminalTabbedView | undefined { return this._terminalTabbedView; } private _isInitialized: boolean = false; /** @@ -280,12 +279,8 @@ export class TerminalViewPane extends ViewPane { } case TerminalCommandId.Focus: { if (action instanceof MenuItemAction) { - if (this._singleTabActionViewItem.value) { - return this._singleTabActionViewItem.value; - } const actions = getFlatContextMenuActions(this._singleTabMenu.getActions({ shouldForwardArgs: true })); - this._singleTabActionViewItem.value = this._instantiationService.createInstance(SingleTerminalTabActionViewItem, action, actions); - return this._singleTabActionViewItem.value; + return this._instantiationService.createInstance(SingleTerminalTabActionViewItem, action, actions); } break; }