Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 02:28:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

add log statements to catch weird bug

Browse Source
This commit is contained in:
Joao Moreno
2018-07-09 17:00:24 +02:00
parent 7059b50648
commit 25cabacf5d
1 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/vs/base/browser/ui/list/listView.ts
View File

@@ -282,6 +282,11 @@ export class ListView<T> implements ISpliceable<T>, IDisposable {
private insertItemInDOM(index: number, beforeElement: HTMLElement | null): void {
const item = this.items[index];
if (!item) {
console.log(this.items);
throw new Error(`Got index ${index} and there are ${this.items.length} items. File issue to joao!`);
}
if (!item.row) {
item.row = this.cache.alloc(item.templateId);
}
@@ -311,6 +316,12 @@ export class ListView<T> implements ISpliceable<T>, IDisposable {
private removeItemFromDOM(index: number): void {
const item = this.items[index];
if (!item) {
console.log(this.items);
throw new Error(`Got index ${index} and there are ${this.items.length} items. File issue to joao!`);
}
this.cache.release(item.row);
item.row = null;
}
@@ -371,7 +382,12 @@ export class ListView<T> implements ISpliceable<T>, IDisposable {
}
private onScroll(e: ScrollEvent): void {
this.render(e.scrollTop, e.height);
try {
this.render(e.scrollTop, e.height);
} catch (err) {
console.log('Got bad scroll event:', e);
throw err;
}
}
private onTouchChange(event: GestureEvent): void {