From 2681e07db46ea2dfe82a407d8a084f0a336df4e0 Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Mon, 1 Feb 2021 14:11:10 +0100 Subject: [PATCH] more notebook todos --- src/vs/vscode.proposed.d.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts index 70566dd2c69..13a31350c9d 100644 --- a/src/vs/vscode.proposed.d.ts +++ b/src/vs/vscode.proposed.d.ts @@ -1480,6 +1480,7 @@ declare module 'vscode' { readonly document: NotebookDocument; } + // todo@API is this still needed? With transient metadata have we everything covered? interface NotebookDocumentEditEvent { /** @@ -1673,8 +1674,10 @@ declare module 'vscode' { export namespace notebook { export function registerNotebookContentProvider( + // TODO@api use NotebookDocumentFilter? notebookType: string, provider: NotebookContentProvider, + // TODO@API is duplicated with a more powerful variant on NotebookContentProvider options?: NotebookDocumentContentOptions & { /** * Not ready for production or development use yet. @@ -2574,7 +2577,7 @@ declare module 'vscode' { export function openExternal(target: Uri, options?: OpenExternalOptions): Thenable; } - //endregionn + //#endregion //#region https://github.com/Microsoft/vscode/issues/15178