diff --git a/src/vs/code/electron-main/menus.ts b/src/vs/code/electron-main/menus.ts index da1ca7c05bb..cbe44d7fe67 100644 --- a/src/vs/code/electron-main/menus.ts +++ b/src/vs/code/electron-main/menus.ts @@ -339,12 +339,12 @@ export class CodeMenu { newFile = this.createMenuItem(nls.localize({ key: 'miNewFile', comment: ['&& denotes a mnemonic'] }, "&&New File"), 'workbench.action.files.newUntitledFile'); } - const open = new MenuItem(this.likeAction('workbench.action.files.openFileFolder', { label: this.mnemonicLabel(nls.localize({ key: 'miOpen', comment: ['&& denotes a mnemonic'] }, "&&Open...")), click: (menuItem, win, event) => this.windowsService.openFileFolderPicker(this.isOptionClick(event), { from: telemetryFrom }) })); - const openFolder = new MenuItem(this.likeAction('workbench.action.files.openFolder', { label: this.mnemonicLabel(nls.localize({ key: 'miOpenFolder', comment: ['&& denotes a mnemonic'] }, "Open &&Folder...")), click: (menuItem, win, event) => this.windowsService.openFolderPicker(this.isOptionClick(event), undefined, { from: telemetryFrom }) })); + const open = new MenuItem(this.likeAction('workbench.action.files.openFileFolder', { label: this.mnemonicLabel(nls.localize({ key: 'miOpen', comment: ['&& denotes a mnemonic'] }, "&&Open...")), click: (menuItem, win, event) => this.windowsService.pickFileFolderAndOpen(this.isOptionClick(event), { from: telemetryFrom }) })); + const openFolder = new MenuItem(this.likeAction('workbench.action.files.openFolder', { label: this.mnemonicLabel(nls.localize({ key: 'miOpenFolder', comment: ['&& denotes a mnemonic'] }, "Open &&Folder...")), click: (menuItem, win, event) => this.windowsService.pickFolderAndOpen(this.isOptionClick(event), undefined, { from: telemetryFrom }) })); let openFile: Electron.MenuItem; if (hasNoWindows) { - openFile = new MenuItem(this.likeAction('workbench.action.files.openFile', { label: this.mnemonicLabel(nls.localize({ key: 'miOpenFile', comment: ['&& denotes a mnemonic'] }, "&&Open File...")), click: (menuItem, win, event) => this.windowsService.openFilePicker(this.isOptionClick(event), undefined, undefined, { from: telemetryFrom }) })); + openFile = new MenuItem(this.likeAction('workbench.action.files.openFile', { label: this.mnemonicLabel(nls.localize({ key: 'miOpenFile', comment: ['&& denotes a mnemonic'] }, "&&Open File...")), click: (menuItem, win, event) => this.windowsService.pickFileAndOpen(this.isOptionClick(event), undefined, undefined, { from: telemetryFrom }) })); } else { openFile = this.createMenuItem(nls.localize({ key: 'miOpenFile', comment: ['&& denotes a mnemonic'] }, "&&Open File..."), ['workbench.action.files.openFile', 'workbench.action.files.openFileInNewWindow']); } diff --git a/src/vs/code/electron-main/windows.ts b/src/vs/code/electron-main/windows.ts index ffab1cb419b..fede11c5cbb 100644 --- a/src/vs/code/electron-main/windows.ts +++ b/src/vs/code/electron-main/windows.ts @@ -1129,15 +1129,15 @@ export class WindowsManager implements IWindowsMainService { this._onWindowClose.fire(win.id); } - public openFileFolderPicker(forceNewWindow?: boolean, data?: ITelemetryData): void { + public pickFileFolderAndOpen(forceNewWindow?: boolean, data?: ITelemetryData): void { this.fileDialog.pickAndOpen({ pickFolders: true, pickFiles: true, forceNewWindow }, 'openFileFolder', data); } - public openFilePicker(forceNewWindow?: boolean, path?: string, window?: CodeWindow, data?: ITelemetryData): void { + public pickFileAndOpen(forceNewWindow?: boolean, path?: string, window?: CodeWindow, data?: ITelemetryData): void { this.fileDialog.pickAndOpen({ pickFiles: true, forceNewWindow, path, window }, 'openFile', data); } - public openFolderPicker(forceNewWindow?: boolean, window?: CodeWindow, data?: ITelemetryData): void { + public pickFolderAndOpen(forceNewWindow?: boolean, window?: CodeWindow, data?: ITelemetryData): void { this.fileDialog.pickAndOpen({ pickFolders: true, forceNewWindow, window }, 'openFolder', data); } diff --git a/src/vs/platform/windows/common/windows.ts b/src/vs/platform/windows/common/windows.ts index 976243684bf..9002bd7e8f8 100644 --- a/src/vs/platform/windows/common/windows.ts +++ b/src/vs/platform/windows/common/windows.ts @@ -21,9 +21,9 @@ export interface IWindowsService { onWindowOpen: Event; onWindowFocus: Event; - openFileFolderPicker(windowId: number, forceNewWindow?: boolean, data?: ITelemetryData): TPromise; - openFilePicker(windowId: number, forceNewWindow?: boolean, path?: string, data?: ITelemetryData): TPromise; - openFolderPicker(windowId: number, forceNewWindow?: boolean, data?: ITelemetryData): TPromise; + pickFileFolderAndOpen(windowId: number, forceNewWindow?: boolean, data?: ITelemetryData): TPromise; + pickFileAndOpen(windowId: number, forceNewWindow?: boolean, path?: string, data?: ITelemetryData): TPromise; + pickFolderAndOpen(windowId: number, forceNewWindow?: boolean, data?: ITelemetryData): TPromise; reloadWindow(windowId: number): TPromise; openDevTools(windowId: number): TPromise; toggleDevTools(windowId: number): TPromise; @@ -74,9 +74,9 @@ export interface IWindowService { _serviceBrand: any; getCurrentWindowId(): number; - openFileFolderPicker(forceNewWindow?: boolean, data?: ITelemetryData): TPromise; - openFilePicker(forceNewWindow?: boolean, path?: string, data?: ITelemetryData): TPromise; - openFolderPicker(forceNewWindow?: boolean, data?: ITelemetryData): TPromise; + pickFileFolderAndOpen(forceNewWindow?: boolean, data?: ITelemetryData): TPromise; + pickFileAndOpen(forceNewWindow?: boolean, path?: string, data?: ITelemetryData): TPromise; + pickFolderAndOpen(forceNewWindow?: boolean, data?: ITelemetryData): TPromise; reloadWindow(): TPromise; openDevTools(): TPromise; toggleDevTools(): TPromise; diff --git a/src/vs/platform/windows/common/windowsIpc.ts b/src/vs/platform/windows/common/windowsIpc.ts index 4edb0401da5..313e5b51135 100644 --- a/src/vs/platform/windows/common/windowsIpc.ts +++ b/src/vs/platform/windows/common/windowsIpc.ts @@ -14,9 +14,9 @@ import { ITelemetryData } from 'vs/platform/telemetry/common/telemetry'; export interface IWindowsChannel extends IChannel { call(command: 'event:onWindowOpen'): TPromise; call(command: 'event:onWindowFocus'): TPromise; - call(command: 'openFileFolderPicker', arg: [number, boolean, ITelemetryData]): TPromise; - call(command: 'openFilePicker', arg: [number, boolean, string, ITelemetryData]): TPromise; - call(command: 'openFolderPicker', arg: [number, boolean, ITelemetryData]): TPromise; + call(command: 'pickFileFolderAndOpen', arg: [number, boolean, ITelemetryData]): TPromise; + call(command: 'pickFileAndOpen', arg: [number, boolean, string, ITelemetryData]): TPromise; + call(command: 'pickFolderAndOpen', arg: [number, boolean, ITelemetryData]): TPromise; call(command: 'reloadWindow', arg: number): TPromise; call(command: 'toggleDevTools', arg: number): TPromise; call(command: 'closeFolder', arg: number): TPromise; @@ -64,9 +64,9 @@ export class WindowsChannel implements IWindowsChannel { switch (command) { case 'event:onWindowOpen': return eventToCall(this.onWindowOpen); case 'event:onWindowFocus': return eventToCall(this.onWindowFocus); - case 'openFileFolderPicker': return this.service.openFileFolderPicker(arg[0], arg[1], arg[2]); - case 'openFilePicker': return this.service.openFilePicker(arg[0], arg[1], arg[2], arg[3]); - case 'openFolderPicker': return this.service.openFolderPicker(arg[0], arg[1], arg[2]); + case 'pickFileFolderAndOpen': return this.service.pickFileFolderAndOpen(arg[0], arg[1], arg[2]); + case 'pickFileAndOpen': return this.service.pickFileAndOpen(arg[0], arg[1], arg[2], arg[3]); + case 'pickFolderAndOpen': return this.service.pickFolderAndOpen(arg[0], arg[1], arg[2]); case 'reloadWindow': return this.service.reloadWindow(arg); case 'openDevTools': return this.service.openDevTools(arg); case 'toggleDevTools': return this.service.toggleDevTools(arg); @@ -115,16 +115,16 @@ export class WindowsChannelClient implements IWindowsService { private _onWindowFocus: Event = eventFromCall(this.channel, 'event:onWindowFocus'); get onWindowFocus(): Event { return this._onWindowFocus; } - openFileFolderPicker(windowId: number, forceNewWindow?: boolean, data?: ITelemetryData): TPromise { - return this.channel.call('openFileFolderPicker', [windowId, forceNewWindow, data]); + pickFileFolderAndOpen(windowId: number, forceNewWindow?: boolean, data?: ITelemetryData): TPromise { + return this.channel.call('pickFileFolderAndOpen', [windowId, forceNewWindow, data]); } - openFilePicker(windowId: number, forceNewWindow?: boolean, path?: string, data?: ITelemetryData): TPromise { - return this.channel.call('openFilePicker', [windowId, forceNewWindow, path, data]); + pickFileAndOpen(windowId: number, forceNewWindow?: boolean, path?: string, data?: ITelemetryData): TPromise { + return this.channel.call('pickFileAndOpen', [windowId, forceNewWindow, path, data]); } - openFolderPicker(windowId: number, forceNewWindow?: boolean, data?: ITelemetryData): TPromise { - return this.channel.call('openFolderPicker', [windowId, forceNewWindow, data]); + pickFolderAndOpen(windowId: number, forceNewWindow?: boolean, data?: ITelemetryData): TPromise { + return this.channel.call('pickFolderAndOpen', [windowId, forceNewWindow, data]); } reloadWindow(windowId: number): TPromise { diff --git a/src/vs/platform/windows/electron-browser/windowService.ts b/src/vs/platform/windows/electron-browser/windowService.ts index 1247697fd17..8db5deb0d79 100644 --- a/src/vs/platform/windows/electron-browser/windowService.ts +++ b/src/vs/platform/windows/electron-browser/windowService.ts @@ -22,16 +22,16 @@ export class WindowService implements IWindowService { return this.windowId; } - openFileFolderPicker(forceNewWindow?: boolean, data?: ITelemetryData): TPromise { - return this.windowsService.openFileFolderPicker(this.windowId, forceNewWindow, data); + pickFileFolderAndOpen(forceNewWindow?: boolean, data?: ITelemetryData): TPromise { + return this.windowsService.pickFileFolderAndOpen(this.windowId, forceNewWindow, data); } - openFilePicker(forceNewWindow?: boolean, path?: string, data?: ITelemetryData): TPromise { - return this.windowsService.openFilePicker(this.windowId, forceNewWindow, path, data); + pickFileAndOpen(forceNewWindow?: boolean, path?: string, data?: ITelemetryData): TPromise { + return this.windowsService.pickFileAndOpen(this.windowId, forceNewWindow, path, data); } - openFolderPicker(forceNewWindow?: boolean, data?: ITelemetryData): TPromise { - return this.windowsService.openFolderPicker(this.windowId, forceNewWindow, data); + pickFolderAndOpen(forceNewWindow?: boolean, data?: ITelemetryData): TPromise { + return this.windowsService.pickFolderAndOpen(this.windowId, forceNewWindow, data); } reloadWindow(): TPromise { diff --git a/src/vs/platform/windows/electron-main/windows.ts b/src/vs/platform/windows/electron-main/windows.ts index 50f47d21104..fa1d6c001c6 100644 --- a/src/vs/platform/windows/electron-main/windows.ts +++ b/src/vs/platform/windows/electron-main/windows.ts @@ -49,9 +49,9 @@ export interface IWindowsMainService { reload(win: ICodeWindow, cli?: ParsedArgs): void; open(openConfig: IOpenConfiguration): ICodeWindow[]; openExtensionDevelopmentHostWindow(openConfig: IOpenConfiguration): void; - openFileFolderPicker(forceNewWindow?: boolean, data?: ITelemetryData): void; - openFilePicker(forceNewWindow?: boolean, path?: string, window?: ICodeWindow, data?: ITelemetryData): void; - openFolderPicker(forceNewWindow?: boolean, window?: ICodeWindow, data?: ITelemetryData): void; + pickFileFolderAndOpen(forceNewWindow?: boolean, data?: ITelemetryData): void; + pickFileAndOpen(forceNewWindow?: boolean, path?: string, window?: ICodeWindow, data?: ITelemetryData): void; + pickFolderAndOpen(forceNewWindow?: boolean, window?: ICodeWindow, data?: ITelemetryData): void; focusLastActive(cli: ParsedArgs, context: OpenContext): ICodeWindow; getLastActiveWindow(): ICodeWindow; findWindow(workspacePath: string, filePath?: string, extensionDevelopmentPath?: string): ICodeWindow; diff --git a/src/vs/platform/windows/electron-main/windowsService.ts b/src/vs/platform/windows/electron-main/windowsService.ts index b20bea84005..1e5bc4b4a2d 100644 --- a/src/vs/platform/windows/electron-main/windowsService.ts +++ b/src/vs/platform/windows/electron-main/windowsService.ts @@ -50,19 +50,19 @@ export class WindowsService implements IWindowsService, IDisposable { .on(this.openExtensionForURI, this, this.disposables); } - openFileFolderPicker(windowId: number, forceNewWindow?: boolean, data?: ITelemetryData): TPromise { - this.windowsMainService.openFileFolderPicker(forceNewWindow, data); + pickFileFolderAndOpen(windowId: number, forceNewWindow?: boolean, data?: ITelemetryData): TPromise { + this.windowsMainService.pickFileFolderAndOpen(forceNewWindow, data); return TPromise.as(null); } - openFilePicker(windowId: number, forceNewWindow?: boolean, path?: string, data?: ITelemetryData): TPromise { - this.windowsMainService.openFilePicker(forceNewWindow, path, undefined, data); + pickFileAndOpen(windowId: number, forceNewWindow?: boolean, path?: string, data?: ITelemetryData): TPromise { + this.windowsMainService.pickFileAndOpen(forceNewWindow, path, undefined, data); return TPromise.as(null); } - openFolderPicker(windowId: number, forceNewWindow?: boolean, data?: ITelemetryData): TPromise { + pickFolderAndOpen(windowId: number, forceNewWindow?: boolean, data?: ITelemetryData): TPromise { const codeWindow = this.windowsMainService.getWindowById(windowId); - this.windowsMainService.openFolderPicker(forceNewWindow, codeWindow, data); + this.windowsMainService.pickFolderAndOpen(forceNewWindow, codeWindow, data); return TPromise.as(null); } diff --git a/src/vs/workbench/api/node/extHostApiCommands.ts b/src/vs/workbench/api/node/extHostApiCommands.ts index aa0e58908e6..86588985765 100644 --- a/src/vs/workbench/api/node/extHostApiCommands.ts +++ b/src/vs/workbench/api/node/extHostApiCommands.ts @@ -181,7 +181,7 @@ export class ExtHostApiCommands { this._register('vscode.openFolder', (uri?: URI, forceNewWindow?: boolean) => { if (!uri) { - return this._commands.executeCommand('_files.openFolderPicker', forceNewWindow); + return this._commands.executeCommand('_files.pickFolderAndOpen', forceNewWindow); } return this._commands.executeCommand('_files.windowOpen', [uri.fsPath], forceNewWindow); diff --git a/src/vs/workbench/browser/actions/fileActions.ts b/src/vs/workbench/browser/actions/fileActions.ts index 13f2694a0fc..d4f21f16f58 100644 --- a/src/vs/workbench/browser/actions/fileActions.ts +++ b/src/vs/workbench/browser/actions/fileActions.ts @@ -25,7 +25,7 @@ export class OpenFolderAction extends Action { } run(event?: any, data?: ITelemetryData): TPromise { - return this.windowService.openFolderPicker(undefined, data); + return this.windowService.pickFolderAndOpen(undefined, data); } } @@ -43,6 +43,6 @@ export class OpenFileFolderAction extends Action { } run(event?: any, data?: ITelemetryData): TPromise { - return this.windowService.openFileFolderPicker(undefined, data); + return this.windowService.pickFileFolderAndOpen(undefined, data); } } diff --git a/src/vs/workbench/parts/files/browser/fileActions.contribution.ts b/src/vs/workbench/parts/files/browser/fileActions.contribution.ts index 1d4140e12f5..2364d54dead 100644 --- a/src/vs/workbench/parts/files/browser/fileActions.contribution.ts +++ b/src/vs/workbench/parts/files/browser/fileActions.contribution.ts @@ -205,7 +205,7 @@ if (isMacintosh) { } // Commands -CommandsRegistry.registerCommand('_files.openFolderPicker', openFolderPickerCommand); +CommandsRegistry.registerCommand('_files.pickFolderAndOpen', openFolderPickerCommand); CommandsRegistry.registerCommand('_files.windowOpen', openWindowCommand); CommandsRegistry.registerCommand('workbench.action.files.openFileInNewWindow', openFileInNewWindowCommand); diff --git a/src/vs/workbench/parts/files/browser/fileActions.ts b/src/vs/workbench/parts/files/browser/fileActions.ts index d66bf8e86c3..3d54573acaa 100644 --- a/src/vs/workbench/parts/files/browser/fileActions.ts +++ b/src/vs/workbench/parts/files/browser/fileActions.ts @@ -1818,7 +1818,7 @@ export class OpenFileAction extends Action { run(event?: any, data?: ITelemetryData): TPromise { const fileResource = toResource(this.editorService.getActiveEditorInput(), { supportSideBySide: true, filter: 'file' }); - return this.windowService.openFilePicker(false, fileResource ? paths.dirname(fileResource.fsPath) : void 0, data); + return this.windowService.pickFileAndOpen(false, fileResource ? paths.dirname(fileResource.fsPath) : void 0, data); } } diff --git a/src/vs/workbench/parts/files/browser/fileCommands.ts b/src/vs/workbench/parts/files/browser/fileCommands.ts index 8d0711a0c3d..393737b1f7a 100644 --- a/src/vs/workbench/parts/files/browser/fileCommands.ts +++ b/src/vs/workbench/parts/files/browser/fileCommands.ts @@ -54,7 +54,7 @@ export const copyPathCommand = (accessor: ServicesAccessor, resource?: URI) => { export const openFolderPickerCommand = (accessor: ServicesAccessor, forceNewWindow: boolean) => { const windowService = accessor.get(IWindowService); - windowService.openFolderPicker(forceNewWindow); + windowService.pickFolderAndOpen(forceNewWindow); }; export const openWindowCommand = (accessor: ServicesAccessor, paths: string[], forceNewWindow: boolean) => { @@ -68,7 +68,7 @@ export const openFileInNewWindowCommand = (accessor: ServicesAccessor) => { const fileResource = toResource(editorService.getActiveEditorInput(), { supportSideBySide: true, filter: 'file' }); - windowService.openFilePicker(true, fileResource ? paths.dirname(fileResource.fsPath) : void 0); + windowService.pickFileAndOpen(true, fileResource ? paths.dirname(fileResource.fsPath) : void 0); }; export const revealInOSCommand = (accessor: ServicesAccessor, resource?: URI) => { diff --git a/src/vs/workbench/test/workbenchTestServices.ts b/src/vs/workbench/test/workbenchTestServices.ts index 342d3631489..e042cf4694b 100644 --- a/src/vs/workbench/test/workbenchTestServices.ts +++ b/src/vs/workbench/test/workbenchTestServices.ts @@ -842,15 +842,15 @@ export class TestWindowService implements IWindowService { return 0; } - openFileFolderPicker(forceNewWindow?: boolean): TPromise { + pickFileFolderAndOpen(forceNewWindow?: boolean): TPromise { return TPromise.as(void 0); } - openFilePicker(forceNewWindow?: boolean, path?: string): TPromise { + pickFileAndOpen(forceNewWindow?: boolean, path?: string): TPromise { return TPromise.as(void 0); } - openFolderPicker(forceNewWindow?: boolean): TPromise { + pickFolderAndOpen(forceNewWindow?: boolean): TPromise { return TPromise.as(void 0); } @@ -961,13 +961,13 @@ export class TestWindowsService implements IWindowsService { return TPromise.as(false); } - openFileFolderPicker(windowId: number, forceNewWindow?: boolean): TPromise { + pickFileFolderAndOpen(windowId: number, forceNewWindow?: boolean): TPromise { return TPromise.as(void 0); } - openFilePicker(windowId: number, forceNewWindow?: boolean, path?: string): TPromise { + pickFileAndOpen(windowId: number, forceNewWindow?: boolean, path?: string): TPromise { return TPromise.as(void 0); } - openFolderPicker(windowId: number, forceNewWindow?: boolean): TPromise { + pickFolderAndOpen(windowId: number, forceNewWindow?: boolean): TPromise { return TPromise.as(void 0); } reloadWindow(windowId: number): TPromise {