From 2ac15236ea0940c34a3367ea4d63de09596ffc32 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Fri, 18 Sep 2020 14:49:55 -0700 Subject: [PATCH] Allow updating the title of a composite even if it is not active (#106892) Fixes #106083 --- src/vs/workbench/browser/parts/compositePart.ts | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/vs/workbench/browser/parts/compositePart.ts b/src/vs/workbench/browser/parts/compositePart.ts index c9c0963fed8..6d9d046678a 100644 --- a/src/vs/workbench/browser/parts/compositePart.ts +++ b/src/vs/workbench/browser/parts/compositePart.ts @@ -284,13 +284,14 @@ export abstract class CompositePart extends Part { protected onTitleAreaUpdate(compositeId: string): void { - // Active Composite + // Title + const compositeItem = this.instantiatedCompositeItems.get(compositeId); + if (compositeItem) { + this.updateTitle(compositeItem.composite.getId(), compositeItem.composite.getTitle()); + } + + // Actions if (this.activeComposite && this.activeComposite.getId() === compositeId) { - - // Title - this.updateTitle(this.activeComposite.getId(), this.activeComposite.getTitle()); - - // Actions const actionsBinding = this.collectCompositeActions(this.activeComposite); this.mapActionsBindingToComposite.set(this.activeComposite.getId(), actionsBinding); actionsBinding();