From 2c4edeb617e41c0222fdd6729794113537eaf331 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Wed, 14 Aug 2019 14:54:09 -0700 Subject: [PATCH] Make sure we compare fully normalized error codes when checking for fix all actions --- .../typescript-language-features/src/features/quickFix.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/extensions/typescript-language-features/src/features/quickFix.ts b/extensions/typescript-language-features/src/features/quickFix.ts index 7bc5d43f0eb..2585142e097 100644 --- a/extensions/typescript-language-features/src/features/quickFix.ts +++ b/extensions/typescript-language-features/src/features/quickFix.ts @@ -290,7 +290,8 @@ class TypeScriptQuickFixProvider implements vscode.CodeActionProvider { if (x === diagnostic) { return false; } - return x.code === diagnostic.code || fixAllErrorCodes.get(x.code as number) === diagnostic.code; + return x.code === diagnostic.code + || (fixAllErrorCodes.has(x.code as number) && fixAllErrorCodes.get(x.code as number) === fixAllErrorCodes.get(diagnostic.code as number)); })) { return results; }