From 2c95aed6eb6b97362d892002f3bbfa84fd2b120d Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Thu, 18 Aug 2016 11:00:10 -0700 Subject: [PATCH] Remove name from terminal API since it's static --- src/vs/vscode.d.ts | 7 ------- src/vs/workbench/api/node/extHostTerminalService.ts | 7 ++----- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/src/vs/vscode.d.ts b/src/vs/vscode.d.ts index 0772e6f97dd..646988fbcc9 100644 --- a/src/vs/vscode.d.ts +++ b/src/vs/vscode.d.ts @@ -2976,13 +2976,6 @@ declare namespace vscode { */ export interface Terminal { - /** - * The name of the terminal. - * - * @readonly - */ - name: string; - /** * Send text to the terminal. * diff --git a/src/vs/workbench/api/node/extHostTerminalService.ts b/src/vs/workbench/api/node/extHostTerminalService.ts index 1216e8952bd..67505e63f8a 100644 --- a/src/vs/workbench/api/node/extHostTerminalService.ts +++ b/src/vs/workbench/api/node/extHostTerminalService.ts @@ -11,14 +11,11 @@ import {MainContext, MainThreadTerminalServiceShape} from './extHost.protocol'; export class ExtHostTerminal implements vscode.Terminal { - public name: string; - private _id: number; private _proxy: MainThreadTerminalServiceShape; private _disposed: boolean; - constructor(proxy: MainThreadTerminalServiceShape, id: number, name?: string) { - this.name = name; + constructor(proxy: MainThreadTerminalServiceShape, id: number) { this._id = id; this._proxy = proxy; } @@ -53,7 +50,7 @@ export class ExtHostTerminalService { public createTerminal(name?: string): TPromise { return this._proxy.$createTerminal(name).then((terminalId) => { - return new ExtHostTerminal(this._proxy, terminalId, name); + return new ExtHostTerminal(this._proxy, terminalId); }); } }