diff --git a/src/vs/workbench/api/node/extHostLanguageFeatures.ts b/src/vs/workbench/api/node/extHostLanguageFeatures.ts index 2b777c8a1cd..d98cc75056c 100644 --- a/src/vs/workbench/api/node/extHostLanguageFeatures.ts +++ b/src/vs/workbench/api/node/extHostLanguageFeatures.ts @@ -88,17 +88,12 @@ class CodeLensAdapter { private static _badCmd: vscode.Command = { command: 'missing', title: '<>' }; - private _documents: ExtHostDocuments; - private _commands: CommandsConverter; - private _heapService: ExtHostHeapService; - private _provider: vscode.CodeLensProvider; - - constructor(documents: ExtHostDocuments, commands: CommandsConverter, heapService: ExtHostHeapService, provider: vscode.CodeLensProvider) { - this._documents = documents; - this._commands = commands; - this._heapService = heapService; - this._provider = provider; - } + constructor( + private readonly _documents: ExtHostDocuments, + private readonly _commands: CommandsConverter, + private readonly _heapService: ExtHostHeapService, + private readonly _provider: vscode.CodeLensProvider + ) { } provideCodeLenses(resource: URI): TPromise { const doc = this._documents.getDocumentData(resource).document; @@ -140,13 +135,11 @@ class CodeLensAdapter { } class DefinitionAdapter { - private _documents: ExtHostDocuments; - private _provider: vscode.DefinitionProvider; - constructor(documents: ExtHostDocuments, provider: vscode.DefinitionProvider) { - this._documents = documents; - this._provider = provider; - } + constructor( + private readonly _documents: ExtHostDocuments, + private readonly _provider: vscode.DefinitionProvider + ) { } provideDefinition(resource: URI, position: IPosition): TPromise { let doc = this._documents.getDocumentData(resource).document; @@ -163,13 +156,11 @@ class DefinitionAdapter { } class ImplementationAdapter { - private _documents: ExtHostDocuments; - private _provider: vscode.ImplementationProvider; - constructor(documents: ExtHostDocuments, provider: vscode.ImplementationProvider) { - this._documents = documents; - this._provider = provider; - } + constructor( + private readonly _documents: ExtHostDocuments, + private readonly _provider: vscode.ImplementationProvider + ) { } provideImplementation(resource: URI, position: IPosition): TPromise { let doc = this._documents.getDocumentData(resource).document; @@ -186,13 +177,11 @@ class ImplementationAdapter { } class TypeDefinitionAdapter { - private _documents: ExtHostDocuments; - private _provider: vscode.TypeDefinitionProvider; - constructor(documents: ExtHostDocuments, provider: vscode.TypeDefinitionProvider) { - this._documents = documents; - this._provider = provider; - } + constructor( + private readonly _documents: ExtHostDocuments, + private readonly _provider: vscode.TypeDefinitionProvider + ) { } provideTypeDefinition(resource: URI, position: IPosition): TPromise { const doc = this._documents.getDocumentData(resource).document; @@ -208,15 +197,12 @@ class TypeDefinitionAdapter { } } - class HoverAdapter { constructor( private readonly _documents: ExtHostDocuments, private readonly _provider: vscode.HoverProvider, - ) { - // - } + ) { } public provideHover(resource: URI, position: IPosition): TPromise { @@ -241,13 +227,10 @@ class HoverAdapter { class DocumentHighlightAdapter { - private _documents: ExtHostDocuments; - private _provider: vscode.DocumentHighlightProvider; - - constructor(documents: ExtHostDocuments, provider: vscode.DocumentHighlightProvider) { - this._documents = documents; - this._provider = provider; - } + constructor( + private readonly _documents: ExtHostDocuments, + private readonly _provider: vscode.DocumentHighlightProvider + ) { } provideDocumentHighlights(resource: URI, position: IPosition): TPromise { @@ -265,13 +248,10 @@ class DocumentHighlightAdapter { class ReferenceAdapter { - private _documents: ExtHostDocuments; - private _provider: vscode.ReferenceProvider; - - constructor(documents: ExtHostDocuments, provider: vscode.ReferenceProvider) { - this._documents = documents; - this._provider = provider; - } + constructor( + private readonly _documents: ExtHostDocuments, + private readonly _provider: vscode.ReferenceProvider + ) { } provideReferences(resource: URI, position: IPosition, context: modes.ReferenceContext): TPromise { let doc = this._documents.getDocumentData(resource).document; @@ -359,13 +339,10 @@ class CodeActionAdapter { class DocumentFormattingAdapter { - private _documents: ExtHostDocuments; - private _provider: vscode.DocumentFormattingEditProvider; - - constructor(documents: ExtHostDocuments, provider: vscode.DocumentFormattingEditProvider) { - this._documents = documents; - this._provider = provider; - } + constructor( + private readonly _documents: ExtHostDocuments, + private readonly _provider: vscode.DocumentFormattingEditProvider + ) { } provideDocumentFormattingEdits(resource: URI, options: modes.FormattingOptions): TPromise { @@ -382,13 +359,10 @@ class DocumentFormattingAdapter { class RangeFormattingAdapter { - private _documents: ExtHostDocuments; - private _provider: vscode.DocumentRangeFormattingEditProvider; - - constructor(documents: ExtHostDocuments, provider: vscode.DocumentRangeFormattingEditProvider) { - this._documents = documents; - this._provider = provider; - } + constructor( + private readonly _documents: ExtHostDocuments, + private readonly _provider: vscode.DocumentRangeFormattingEditProvider + ) { } provideDocumentRangeFormattingEdits(resource: URI, range: IRange, options: modes.FormattingOptions): TPromise { @@ -406,13 +380,10 @@ class RangeFormattingAdapter { class OnTypeFormattingAdapter { - private _documents: ExtHostDocuments; - private _provider: vscode.OnTypeFormattingEditProvider; - - constructor(documents: ExtHostDocuments, provider: vscode.OnTypeFormattingEditProvider) { - this._documents = documents; - this._provider = provider; - } + constructor( + private readonly _documents: ExtHostDocuments, + private readonly _provider: vscode.OnTypeFormattingEditProvider + ) { } autoFormatTriggerCharacters: string[] = []; // not here @@ -498,13 +469,10 @@ class RenameAdapter { return typeof provider.prepareRename === 'function'; } - private _documents: ExtHostDocuments; - private _provider: vscode.RenameProvider; - - constructor(documents: ExtHostDocuments, provider: vscode.RenameProvider) { - this._documents = documents; - this._provider = provider; - } + constructor( + private readonly _documents: ExtHostDocuments, + private readonly _provider: vscode.RenameProvider + ) { } provideRenameEdits(resource: URI, position: IPosition, newName: string): TPromise { @@ -733,13 +701,10 @@ class SuggestAdapter { class SignatureHelpAdapter { - private _documents: ExtHostDocuments; - private _provider: vscode.SignatureHelpProvider; - - constructor(documents: ExtHostDocuments, provider: vscode.SignatureHelpProvider) { - this._documents = documents; - this._provider = provider; - } + constructor( + private readonly _documents: ExtHostDocuments, + private readonly _provider: vscode.SignatureHelpProvider + ) { } provideSignatureHelp(resource: URI, position: IPosition): TPromise { @@ -757,15 +722,11 @@ class SignatureHelpAdapter { class LinkProviderAdapter { - private _documents: ExtHostDocuments; - private _heapService: ExtHostHeapService; - private _provider: vscode.DocumentLinkProvider; - - constructor(documents: ExtHostDocuments, heapService: ExtHostHeapService, provider: vscode.DocumentLinkProvider) { - this._documents = documents; - this._heapService = heapService; - this._provider = provider; - } + constructor( + private readonly _documents: ExtHostDocuments, + private readonly _heapService: ExtHostHeapService, + private readonly _provider: vscode.DocumentLinkProvider + ) { } provideLinks(resource: URI): TPromise { const doc = this._documents.getDocumentData(resource).document;