From 2de60eada57a6ea88a11ff72091e26b2825e84af Mon Sep 17 00:00:00 2001 From: Kyle Cutler <67761731+kycutler@users.noreply.github.com> Date: Fri, 27 Mar 2026 17:11:21 -0700 Subject: [PATCH] Better syncing of "share with agent" status (#305854) --- .../platform/browserView/node/playwrightService.ts | 12 +++--------- .../contrib/browserView/common/browserView.ts | 2 ++ 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/vs/platform/browserView/node/playwrightService.ts b/src/vs/platform/browserView/node/playwrightService.ts index 8abf560a5c3..70fba85e7d0 100644 --- a/src/vs/platform/browserView/node/playwrightService.ts +++ b/src/vs/platform/browserView/node/playwrightService.ts @@ -424,21 +424,15 @@ class PlaywrightPageManager extends Disposable { try { await this._group!.addView(viewId); - } catch (err: unknown) { - const errorMessage = err instanceof Error ? err.message : String(err); - this.logService.error('[PlaywrightPageManager] Failed to add view:', errorMessage); + } catch (err) { this.onViewRemoved(viewId); + throw err; } } private async _removePageFromGroup(viewId: string): Promise { this.onViewRemoved(viewId); - try { - await this._group!.removeView(viewId); - } catch (err: unknown) { - const errorMessage = err instanceof Error ? err.message : String(err); - this.logService.error('[PlaywrightPageManager] Failed to remove view:', errorMessage); - } + await this._group!.removeView(viewId); } private _fireTrackedPagesChanged(): void { diff --git a/src/vs/workbench/contrib/browserView/common/browserView.ts b/src/vs/workbench/contrib/browserView/common/browserView.ts index 5508cfc68eb..ea849772f16 100644 --- a/src/vs/workbench/contrib/browserView/common/browserView.ts +++ b/src/vs/workbench/contrib/browserView/common/browserView.ts @@ -606,8 +606,10 @@ export class BrowserViewModel extends Disposable implements IBrowserViewModel { } await this.playwrightService.startTrackingPage(this.id); + this._setSharedWithAgent(true); } else { await this.playwrightService.stopTrackingPage(this.id); + this._setSharedWithAgent(false); } }