From 30f2cec7953cbb118490c3bf79ebda2bc980edd9 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Wed, 15 Jan 2020 23:34:48 -0800 Subject: [PATCH] Try moving keytar to externals This attempts to fix an extension compile error introduced with 3d933fb742e208262804f5398270225888bb8365 The issue is that keytar loads a `.node` file, which webpack is not able to understand --- extensions/vscode-account/extension.webpack.config.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/extensions/vscode-account/extension.webpack.config.js b/extensions/vscode-account/extension.webpack.config.js index de88398eca0..aa95271f3a3 100644 --- a/extensions/vscode-account/extension.webpack.config.js +++ b/extensions/vscode-account/extension.webpack.config.js @@ -16,5 +16,8 @@ module.exports = withDefaults({ }, entry: { extension: './src/extension.ts', - } + }, + externals: { + 'keytar': 'commonjs keytar', + }, });