Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-20 02:08:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: remove legacy server support (#235232)

Browse Source 
* build: remove legacy server support

* chore: update rpm dependencies

* chore: fix publishing

* cli: provide option for unsupported glibc sysroot

* chore: add unsupported mode to prereq check

* chore: add logging

* chore: add comment about patchelf execution order
This commit is contained in:
Robo
2025-03-11 01:54:23 +09:00
committed by GitHub
parent 1e271e0428
commit 31ec1c528f
16 changed files with 86 additions and 407 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
cli/src/util/prereqs.rs
View File

@@ -20,19 +20,16 @@ lazy_static! {
static ref LIBSTD_CXX_VERSION_RE: BinRegex =
BinRegex::new(r"GLIBCXX_([0-9]+)\.([0-9]+)(?:\.([0-9]+))?").unwrap();
static ref MIN_LDD_VERSION: SimpleSemver = SimpleSemver::new(2, 28, 0);
static ref MIN_LEGACY_LDD_VERSION: SimpleSemver = SimpleSemver::new(2, 17, 0);
}
#[cfg(target_arch = "arm")]
lazy_static! {
static ref MIN_CXX_VERSION: SimpleSemver = SimpleSemver::new(3, 4, 26);
static ref MIN_LEGACY_CXX_VERSION: SimpleSemver = SimpleSemver::new(3, 4, 22);
}
#[cfg(not(target_arch = "arm"))]
lazy_static! {
static ref MIN_CXX_VERSION: SimpleSemver = SimpleSemver::new(3, 4, 25);
static ref MIN_LEGACY_CXX_VERSION: SimpleSemver = SimpleSemver::new(3, 4, 19);
}
const NIXOS_TEST_PATH: &str = "/etc/NIXOS";
@@ -74,12 +71,11 @@ impl PreReqChecker {
} else {
println!("!!! WARNING: Skipping server pre-requisite check !!!");
println!("!!! Server stability is not guaranteed. Proceed at your own risk. !!!");
// Use the legacy server for #210029
(Ok(true), Ok(true))
};
match (&gnu_a, &gnu_b, is_nixos) {
(Ok(false), Ok(false), _) | (_, _, true) => {
(Ok(true), Ok(true), _) | (_, _, true) => {
return Ok(if cfg!(target_arch = "x86_64") {
Platform::LinuxX64
} else if cfg!(target_arch = "arm") {
@@ -88,15 +84,6 @@ impl PreReqChecker {
Platform::LinuxARM64
});
}
(Ok(_), Ok(_), _) => {
return Ok(if cfg!(target_arch = "x86_64") {
Platform::LinuxX64Legacy
} else if cfg!(target_arch = "arm") {
Platform::LinuxARM32Legacy
} else {
Platform::LinuxARM64Legacy
});
}
_ => {}
};
@@ -149,7 +136,7 @@ async fn check_musl_interpreter() -> Result<(), String> {
Ok(())
}
/// Checks the glibc version, returns "true" if the legacy server is required.
/// Checks the glibc version, returns "true" if the default server is required.
#[cfg(target_os = "linux")]
async fn check_glibc_version() -> Result<bool, String> {
#[cfg(target_env = "gnu")]
@@ -170,8 +157,6 @@ async fn check_glibc_version() -> Result<bool, String> {
if let Some(v) = version {
return if v >= *MIN_LDD_VERSION {
Ok(false)
} else if v >= *MIN_LEGACY_LDD_VERSION {
Ok(true)
} else {
Err(format!(
"find GLIBC >= {} (but found {} instead) for GNU environments",
@@ -192,10 +177,17 @@ async fn check_is_nixos() -> bool {
/// Do not remove this check.
/// Provides a way to skip the server glibc requirements check from
/// outside the install flow. A system process can create this
/// file before the server is downloaded and installed.
/// outside the install flow.
///
/// 1) A system process can create this
/// file before the server is downloaded and installed.
///
/// 2) An environment variable declared in host
/// that contains path to a glibc sysroot satisfying the
/// minimum requirements.
#[cfg(not(windows))]
pub async fn skip_requirements_check() -> bool {
std::env::var("VSCODE_SERVER_CUSTOM_GLIBC_LINKER").is_ok() ||
fs::metadata("/tmp/vscode-skip-server-requirements-check")
.await
.is_ok()
@@ -206,7 +198,7 @@ pub async fn skip_requirements_check() -> bool {
false
}
/// Checks the glibc++ version, returns "true" if the legacy server is required.
/// Checks the glibc++ version, returns "true" if the default server is required.
#[cfg(target_os = "linux")]
async fn check_glibcxx_version() -> Result<bool, String> {
let mut libstdc_path: Option<String> = None;
@@ -250,10 +242,6 @@ fn check_for_sufficient_glibcxx_versions(contents: Vec<u8>) -> Result<bool, Stri
if let Some(max_version) = &max_version {
if max_version >= &*MIN_CXX_VERSION {
return Ok(false);
}
if max_version >= &*MIN_LEGACY_CXX_VERSION {
return Ok(true);
}
}