Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 02:28:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

Strict null work in comments

Browse Source 
Lots of null supressions. Will open issue to track removal
This commit is contained in:
Matt Bierner
2019-03-13 11:24:48 -07:00
parent 2d151ddbd1
commit 32afa6d121
7 changed files with 84 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/vs/workbench/api/node/extHostComments.ts
View File

@@ -385,7 +385,7 @@ export class ExtHostCommentThread implements vscode.CommentThread {
private _collapseState?: vscode.CommentThreadCollapsibleState;
get collapsibleState(): vscode.CommentThreadCollapsibleState {
return this._collapseState;
return this._collapseState!;
}
set collapsibleState(newState: vscode.CommentThreadCollapsibleState) {
@@ -410,7 +410,7 @@ export class ExtHostCommentThread implements vscode.CommentThread {
this._comments.map(comment => { return convertToModeComment(comment, this._commandsConverter); }),
this._acceptInputCommand ? this._commandsConverter.toInternal(this._acceptInputCommand) : undefined,
this._additionalCommands ? this._additionalCommands.map(x => this._commandsConverter.toInternal(x)) : [],
this._collapseState
this._collapseState!
);
}
@@ -541,8 +541,8 @@ function convertToCommentThread(extensionId: ExtensionIdentifier, provider: vsco
function convertFromCommentThread(commentThread: modes.CommentThread): vscode.CommentThread {
return {
threadId: commentThread.threadId,
resource: URI.parse(commentThread.resource),
threadId: commentThread.threadId!,
resource: URI.parse(commentThread.resource!),
range: extHostTypeConverter.Range.to(commentThread.range),
comments: commentThread.comments.map(convertFromComment),
collapsibleState: commentThread.collapsibleState