From 2225c4b03fff356e98229b24c044845ccf052b38 Mon Sep 17 00:00:00 2001 From: Pine Wu Date: Wed, 12 Oct 2016 09:13:29 -0700 Subject: [PATCH 1/3] Put extensions as in a GH table in issue template --- src/vs/workbench/electron-browser/actions.ts | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/electron-browser/actions.ts b/src/vs/workbench/electron-browser/actions.ts index dc0a8e91145..507ef58aae6 100644 --- a/src/vs/workbench/electron-browser/actions.ts +++ b/src/vs/workbench/electron-browser/actions.ts @@ -562,7 +562,11 @@ export class ReportIssueAction extends Action { const body = encodeURIComponent( `- VSCode Version: ${name} ${version}${isPure ? '' : ' **[Unsupported]**'} (${product.commit || 'Commit unknown'}, ${product.date || 'Date unknown'}) - OS Version: ${osVersion} -- Extensions: ${extensions.map(e => e.id).join(', ')} +- Extensions: + +${this.generateExtensionTable(extensions)} + +--- Steps to Reproduce: @@ -572,6 +576,16 @@ Steps to Reproduce: return `${baseUrl}${queryStringPrefix}body=${body}`; } + + private generateExtensionTable(extensions: ILocalExtension[]): string { + let tableHeader = `| Extension | Author | Version | +| --- | --- | --- |`; + const table = extensions.map(e => { + return `| ${e.manifest.name} | ${e.manifest.publisher} | ${e.manifest.version} |`; + }).join('\n'); + + return tableHeader + '\n' + table; + } } // --- commands From 02f6a413983d50eb6823d7036bcbcedbe15476c6 Mon Sep 17 00:00:00 2001 From: Pine Wu Date: Wed, 12 Oct 2016 09:19:42 -0700 Subject: [PATCH 2/3] Add link to marketplace --- src/vs/workbench/electron-browser/actions.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/electron-browser/actions.ts b/src/vs/workbench/electron-browser/actions.ts index 507ef58aae6..f058c4fec26 100644 --- a/src/vs/workbench/electron-browser/actions.ts +++ b/src/vs/workbench/electron-browser/actions.ts @@ -581,7 +581,8 @@ Steps to Reproduce: let tableHeader = `| Extension | Author | Version | | --- | --- | --- |`; const table = extensions.map(e => { - return `| ${e.manifest.name} | ${e.manifest.publisher} | ${e.manifest.version} |`; + const marketplaceLink = `https://marketplace.visualstudio.com/items?itemName=${e.manifest.publisher}.${e.manifest.name}`; + return `| [${e.manifest.name}](${marketplaceLink}) | ${e.manifest.publisher} | ${e.manifest.version} |`; }).join('\n'); return tableHeader + '\n' + table; From b72968334db049e21731c2cf9946aec19680f69f Mon Sep 17 00:00:00 2001 From: Pine Wu Date: Tue, 18 Oct 2016 09:18:41 -0700 Subject: [PATCH 3/3] Reduce query length by removing whitespace and link --- src/vs/workbench/electron-browser/actions.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/vs/workbench/electron-browser/actions.ts b/src/vs/workbench/electron-browser/actions.ts index f058c4fec26..ec56306aa55 100644 --- a/src/vs/workbench/electron-browser/actions.ts +++ b/src/vs/workbench/electron-browser/actions.ts @@ -578,11 +578,10 @@ Steps to Reproduce: } private generateExtensionTable(extensions: ILocalExtension[]): string { - let tableHeader = `| Extension | Author | Version | -| --- | --- | --- |`; + let tableHeader = `|Extension|Author|Version| +|---|---|---|`; const table = extensions.map(e => { - const marketplaceLink = `https://marketplace.visualstudio.com/items?itemName=${e.manifest.publisher}.${e.manifest.name}`; - return `| [${e.manifest.name}](${marketplaceLink}) | ${e.manifest.publisher} | ${e.manifest.version} |`; + return `|${e.manifest.name}|${e.manifest.publisher}|${e.manifest.version}|`; }).join('\n'); return tableHeader + '\n' + table;