From 33a08dc6f4386aaa7067575dc8929183df080ae2 Mon Sep 17 00:00:00 2001 From: Megan Rogge Date: Thu, 28 Jul 2022 11:40:11 -0700 Subject: [PATCH] use `task` instead of `taskName` (#156603) fix #155635 --- .../contrib/tasks/browser/abstractTaskService.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts b/src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts index 3a0c564b42b..18a68093766 100644 --- a/src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts +++ b/src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts @@ -398,9 +398,9 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer type: 'string', description: nls.localize('runTask.type', "The contributed task type") }, - taskName: { + task: { type: 'string', - description: nls.localize('runTask.taskName', "The task's label or a term to filter by") + description: nls.localize('runTask.task', "The task's label or a term to filter by") } } } @@ -2700,7 +2700,7 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer })) === true; } - private async _runTaskCommand(filter?: { type?: string; taskName?: string } | string): Promise { + private async _runTaskCommand(filter?: any | { type?: string; task?: string }): Promise { if (!this._canRunCommand()) { return; } @@ -2708,8 +2708,8 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer let typeFilter: boolean = false; if (filter && typeof filter !== 'string') { // name takes precedence - typeFilter = !filter?.taskName && !!filter?.type; - filter = filter?.taskName || filter?.type; + typeFilter = !filter?.task && !!filter?.type; + filter = filter?.task || filter?.type; } const taskIdentifier: KeyedTaskIdentifier | undefined | string = this._getTaskIdentifier(filter);