Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-26 19:44:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

extensions can become obsolete, so delete them on startup

Browse Source 
fixes #2096
This commit is contained in:
Joao Moreno
2016-01-27 18:07:10 +01:00
parent f8836d7698
commit 37c2157978
2 changed files with 108 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/vs/workbench/node/extensionPoints.ts
View File

@@ -101,17 +101,29 @@ export class PluginScanner {
isBuiltin:boolean
) : TPromise<IPluginDescription[]>
{
return pfs.readDirsInDir(absoluteFolderPath)
.then(folders => TPromise.join(folders.map(f => this.scanPlugin(version, collector, paths.join(absoluteFolderPath, f), isBuiltin))))
.then(plugins => plugins.filter(item => item !== null))
.then(plugins => {
const pluginsById = values(groupBy(plugins, p => p.id));
return pluginsById.map(p => p.sort((a, b) => semver.rcompare(a.version, b.version))[0]);
})
.then(null, err => {
collector.error(absoluteFolderPath, err);
return [];
});
let obsolete = TPromise.as({});
if (!isBuiltin) {
obsolete = pfs.readFile(paths.join(absoluteFolderPath, '.obsolete'), 'utf8')
.then(raw => JSON.parse(raw))
.then(null, err => ({}));
}
return obsolete.then(obsolete => {
return pfs.readDirsInDir(absoluteFolderPath)
.then(folders => TPromise.join(folders.map(f => this.scanPlugin(version, collector, paths.join(absoluteFolderPath, f), isBuiltin))))
.then(plugins => plugins.filter(item => item !== null))
// TODO: align with extensionsService
.then(plugins => plugins.filter(p => !obsolete[`${ p.publisher }.${ p.name }-${ p.version }`]))
.then(plugins => {
const pluginsById = values(groupBy(plugins, p => p.id));
return pluginsById.map(p => p.sort((a, b) => semver.rcompare(a.version, b.version))[0]);
})
.then(null, err => {
collector.error(absoluteFolderPath, err);
return [];
});
});
}
/**