Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 18:49:00 +01:00
Code Issues Packages Projects Releases Wiki Activity

Dispose commentcontrol properly.

Browse Source
This commit is contained in:
Peng Lyu
2019-02-22 11:29:58 -08:00
parent bcc48091d3
commit 39218635a5
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/vs/workbench/api/node/extHostComments.ts
View File

@@ -414,9 +414,6 @@ class ExtHostCommentControl implements vscode.CommentControl {
createCommentThread(id: string, resource: vscode.Uri, range: vscode.Range, comments: vscode.Comment[], acceptInputCommands: vscode.Command[], collapsibleState?: vscode.CommentThreadCollapsibleState): vscode.CommentThread {
const commentThread = new ExtHostCommentThread(this._proxy, this._commandsConverter, this.handle, id, resource, range, comments, acceptInputCommands, collapsibleState);
this._threads.set(commentThread.handle, commentThread);
// onDidDispose
return commentThread;
}
@@ -439,7 +436,12 @@ class ExtHostCommentControl implements vscode.CommentControl {
}
dispose(): void {
throw new Error('Method not implemented.');
this._threads.forEach(value => {
value.dispose();
});
this._commentingRanges.forEach(value => {
value.dispose();
});
}
}