Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-24 12:19:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not suggest dot files in html/css. Fix #46780

Browse Source
This commit is contained in:
Pine Wu
2018-09-18 11:38:09 -07:00
parent 9040bf6802
commit 39fbbf02c4
6 changed files with 37 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
extensions/html-language-features/server/src/modes/pathCompletion.ts
View File

@@ -78,11 +78,12 @@ function providePaths(valueBeforeCursor: string, activeDocFsPath: string, root?:
}
try {
return fs.readdirSync(parentDir).map(f => {
const paths = fs.readdirSync(parentDir).map(f => {
return isDir(path.resolve(parentDir, f))
? f + '/'
: f;
});
return paths.filter(p => p[0] !== '.');
} catch (e) {
return [];
}

10
extensions/html-language-features/server/src/test/completions.test.ts
View File

@@ -66,7 +66,7 @@ export function testCompletionFor(value: string, expected: { count?: number, ite
let list = mode.doComplete!(document, position);
if (expected.count) {
assert.equal(list.items, expected.count);
assert.equal(list.items.length, expected.count);
}
if (expected.items) {
for (let item of expected.items) {
@@ -96,7 +96,7 @@ suite('HTML Path Completion', () => {
command: 'editor.action.triggerSuggest'
};
const fixtureRoot = path.resolve(__dirname, 'pathCompletionFixtures');
const fixtureRoot = path.resolve(__dirname, '../../src/test/pathCompletionFixtures');
const fixtureWorkspace = { name: 'fixture', uri: Uri.file(fixtureRoot).toString() };
const indexHtmlUri = Uri.file(path.resolve(fixtureRoot, 'index.html')).toString();
const aboutHtmlUri = Uri.file(path.resolve(fixtureRoot, 'about/about.html')).toString();
@@ -296,6 +296,12 @@ suite('HTML Path Completion', () => {
]
}, indexHtmlUri, [fixtureWorkspace]);
});
test('Completion should ignore files/folders starting with dot', () => {
testCompletionFor('<script src="./|"', {
count: 3
}, indexHtmlUri, [fixtureWorkspace]);
});
test('Unquoted Path', () => {
/* Unquoted value is not supported in html language service yet

4
extensions/html-language-features/server/src/test/pathCompletionFixtures/.foo.js Normal file
View File

@@ -0,0 +1,4 @@
/*---------------------------------------------------------------------------------------------
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/