From 3a02184d40b9878346e5a21d24ec79a7fd896de5 Mon Sep 17 00:00:00 2001 From: Raymond Zhao <7199958+rzhao271@users.noreply.github.com> Date: Mon, 30 Sep 2024 11:02:27 -0700 Subject: [PATCH] Fix more type assertions for #211878 (#230143) Fix unsafe type assertion for mainThreadTask.ts --- src/vs/workbench/api/browser/mainThreadTask.ts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/api/browser/mainThreadTask.ts b/src/vs/workbench/api/browser/mainThreadTask.ts index 3dc0326ef05..52e977fe25d 100644 --- a/src/vs/workbench/api/browser/mainThreadTask.ts +++ b/src/vs/workbench/api/browser/mainThreadTask.ts @@ -34,6 +34,7 @@ import { import { IConfigurationResolverService } from '../../services/configurationResolver/common/configurationResolver.js'; import { ConfigurationTarget } from '../../../platform/configuration/common/configuration.js'; import { ErrorNoTelemetry } from '../../../base/common/errors.js'; +import { IExtensionDescription } from '../../../platform/extensions/common/extensions.js'; namespace TaskExecutionDTO { export function from(value: ITaskExecution): ITaskExecutionDTO { @@ -489,10 +490,14 @@ export class MainThreadTask extends Disposable implements MainThreadTaskShape { console.error(`Task System: can not convert task: ${JSON.stringify(dto.definition, undefined, 0)}. Task will be dropped`); } } + const processedExtension: IExtensionDescription = { + ...value.extension, + extensionLocation: URI.revive(value.extension.extensionLocation) + }; return { tasks, - extension: value.extension - } as ITaskSet; + extension: processedExtension + } satisfies ITaskSet; }); }, resolveTask: (task: ConfiguringTask) => {