From 3c463a2076ef0f2c8ef838bfc4e31fa7e3ca119a Mon Sep 17 00:00:00 2001 From: Alex Dima Date: Tue, 20 Oct 2020 09:46:48 +0200 Subject: [PATCH] Fixes #108880 --- .../services/keybinding/common/macLinuxKeyboardMapper.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/vs/workbench/services/keybinding/common/macLinuxKeyboardMapper.ts b/src/vs/workbench/services/keybinding/common/macLinuxKeyboardMapper.ts index 86f63f04b56..7e2d9d6d17c 100644 --- a/src/vs/workbench/services/keybinding/common/macLinuxKeyboardMapper.ts +++ b/src/vs/workbench/services/keybinding/common/macLinuxKeyboardMapper.ts @@ -956,6 +956,12 @@ export class MacLinuxKeyboardMapper implements IKeyboardMapper { } } + // See https://github.com/microsoft/vscode/issues/108880 + if (binding.ctrlKey && !binding.metaKey && !binding.altKey && constantKeyCode === KeyCode.US_MINUS) { + // ctrl+- and ctrl+shift+- render very similarly in native macOS menus, leading to confusion + return null; + } + if (constantKeyCode !== -1) { return this._getElectronLabelForKeyCode(constantKeyCode); }