From 3cb5a841253222d4c103b61ba3248918ece6932f Mon Sep 17 00:00:00 2001 From: Megan Rogge Date: Wed, 7 Aug 2024 05:49:59 -0700 Subject: [PATCH] respect `waitOnExit` behavior (#224953) check waitOnExit #224418 --- src/vs/workbench/contrib/terminal/browser/terminalInstance.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts index 7d148c92b17..4435b45e013 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts @@ -1160,7 +1160,7 @@ export class TerminalInstance extends Disposable implements ITerminalInstance { } override dispose(reason?: TerminalExitReason): void { - if (this.shellLaunchConfig.type === 'Task' && reason === TerminalExitReason.Process && this._exitCode !== 0) { + if (this.shellLaunchConfig.type === 'Task' && reason === TerminalExitReason.Process && this._exitCode !== 0 && !this.shellLaunchConfig.waitOnExit) { return; } if (this.isDisposed) {