Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-18 23:59:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

Clearer Settings UI for new telemetry setting (#135028)

Browse Source 
* Work on improving telemetry setting description

* two options

* third option

* Add old crash reporter to getTelemetryLevel

* More verbose wording + comments

Co-authored-by: SteVen Batten <sbatten@microsoft.com>
This commit is contained in:
Logan Ramos
2021-10-13 15:03:12 -04:00
committed by GitHub
parent 6e0f56f0a9
commit 3cce1d2c25
5 changed files with 55 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/vs/code/electron-main/app.ts
View File

@@ -990,9 +990,8 @@ export class CodeApplication extends Disposable {
const argvString = argvContent.value.toString();
const argvJSON = JSON.parse(stripComments(argvString));
if (argvJSON['enable-crash-reporter'] === undefined) {
const telemetryConfig = getTelemetryLevel(this.configurationService);
const enableCrashReporterSetting = telemetryConfig >= TelemetryLevel.ERROR;
const enableCrashReporter = typeof enableCrashReporterSetting === 'boolean' ? enableCrashReporterSetting : true;
const telemetryLevel = getTelemetryLevel(this.configurationService);
const enableCrashReporter = telemetryLevel >= TelemetryLevel.CRASH;
const additionalArgvContent = [
'',
' // Allows to disable crash reporting.',