Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-20 02:08:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #245361 from microsoft/revert-245148-senior-goose

Browse Source 
Revert "change telemetry var name"
This commit is contained in:
Daniel Imms
2025-04-02 10:52:52 -07:00
committed by GitHub
parent f096fc7960 a1ac6780c6
commit 3d6eb63d45
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalSuggestTelemetry.ts
View File

@@ -58,19 +58,19 @@ export class TerminalSuggestTelemetry extends Disposable {
return; return;
} }
let completionOutcome: string; let outcome: string;
if (fromInterrupt) { if (fromInterrupt) {
completionOutcome = CompletionOutcome.Interrupted; outcome = CompletionOutcome.Interrupted;
} else if (commandLine.trim() && commandLine.includes(label)) { } else if (commandLine.trim() && commandLine.includes(label)) {
completionOutcome = CompletionOutcome.Accepted; outcome = CompletionOutcome.Accepted;
} else if (inputContainsFirstHalfOfLabel(commandLine, label)) { } else if (inputContainsFirstHalfOfLabel(commandLine, label)) {
completionOutcome = CompletionOutcome.AcceptedWithEdit; outcome = CompletionOutcome.AcceptedWithEdit;
} else { } else {
completionOutcome = CompletionOutcome.Deleted; outcome = CompletionOutcome.Deleted;
} }
this._telemetryService.publicLog2<{ this._telemetryService.publicLog2<{
kind: string | undefined; kind: string | undefined;
completionOutcome: string; outcome: string;
exitCode: number | undefined; exitCode: number | undefined;
}, { }, {
owner: 'meganrogge'; owner: 'meganrogge';
@@ -80,10 +80,10 @@ export class TerminalSuggestTelemetry extends Disposable {
purpose: 'FeatureInsight'; purpose: 'FeatureInsight';
comment: 'The completion item\'s kind'; comment: 'The completion item\'s kind';
}; };
completionOutcome: { outcome: {
classification: 'SystemMetaData'; classification: 'SystemMetaData';
purpose: 'FeatureInsight'; purpose: 'FeatureInsight';
comment: 'The outcome of the completion'; comment: 'The outcome of the accepted completion';
}; };
exitCode: { exitCode: {
classification: 'SystemMetaData'; classification: 'SystemMetaData';
@@ -92,7 +92,7 @@ export class TerminalSuggestTelemetry extends Disposable {
}; };
}>('terminal.suggest.acceptedCompletion', { }>('terminal.suggest.acceptedCompletion', {
kind, kind,
completionOutcome, outcome,
exitCode exitCode
}); });
} }