Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-21 00:59:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Dispose data listener before disposing terminal

Browse Source 
Fixes #95945
This commit is contained in:
Daniel Imms
2020-04-23 07:29:47 -07:00
parent 84a884a97a
commit 3d7745d6fc
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts
View File

@@ -45,7 +45,7 @@ import { doesNotThrow, equal, ok, deepEqual, throws } from 'assert';
return;
}
let data = '';
disposables.push(window.onDidWriteTerminalData(e => {
const dataDisposable = window.onDidWriteTerminalData(e => {
try {
equal(terminal, e.terminal);
} catch (e) {
@@ -54,10 +54,12 @@ import { doesNotThrow, equal, ok, deepEqual, throws } from 'assert';
}
data += e.data;
if (data.indexOf(expected) !== 0) {
dataDisposable.dispose();
terminal.dispose();
disposables.push(window.onDidCloseTerminal(() => done()));
}
}));
});
disposables.push(dataDisposable);
}));
// Use a single character to avoid winpty/conpty issues with injected sequences
const expected = '`';