From 3d79cbb912d1fca00c652daeabd41e64857d7d76 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Thu, 13 Jan 2022 16:38:45 -0800 Subject: [PATCH] Fix markdown path suggestions on windows --- .../src/features/pathCompletions.ts | 10 +++++++--- .../src/test/pathCompletion.test.ts | 3 +-- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/extensions/markdown-language-features/src/features/pathCompletions.ts b/extensions/markdown-language-features/src/features/pathCompletions.ts index 0e419a45a19..3ff2dd945c9 100644 --- a/extensions/markdown-language-features/src/features/pathCompletions.ts +++ b/extensions/markdown-language-features/src/features/pathCompletions.ts @@ -269,9 +269,13 @@ export class PathCompletionProvider implements vscode.CompletionItemProvider { } try { - return document.uri.with({ - path: resolve(dirname(document.uri.path), ref), - }); + if (document.uri.scheme === 'file') { + return vscode.Uri.file(resolve(dirname(document.uri.fsPath), ref)); + } else { + return document.uri.with({ + path: resolve(dirname(document.uri.path), ref), + }); + } } catch (e) { return undefined; } diff --git a/extensions/markdown-language-features/src/test/pathCompletion.test.ts b/extensions/markdown-language-features/src/test/pathCompletion.test.ts index c950ca4da54..6f7365116ab 100644 --- a/extensions/markdown-language-features/src/test/pathCompletion.test.ts +++ b/extensions/markdown-language-features/src/test/pathCompletion.test.ts @@ -26,8 +26,7 @@ function getCompletionsAtCursor(resource: vscode.Uri, fileContents: string) { }); } - -suite.skip('Markdown path completion provider', () => { +suite('Markdown path completion provider', () => { setup(async () => { // These tests assume that the markdown completion provider is already registered