From 1c3473d381585ba9ed4c6829bff50b51f662ce9d Mon Sep 17 00:00:00 2001 From: meganrogge Date: Fri, 3 Nov 2023 14:20:57 -0700 Subject: [PATCH 1/3] fix #197411 --- .../workbench/contrib/accessibility/browser/accessibleView.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/accessibility/browser/accessibleView.ts b/src/vs/workbench/contrib/accessibility/browser/accessibleView.ts index ba589283613..7fcca360f35 100644 --- a/src/vs/workbench/contrib/accessibility/browser/accessibleView.ts +++ b/src/vs/workbench/contrib/accessibility/browser/accessibleView.ts @@ -778,5 +778,5 @@ function shouldHide(event: KeyboardEvent, keybindingService: IKeybindingService) } function shouldHandleKey(event: KeyboardEvent): boolean { - return !!event.code.match(/^Key{A-Z}|Digit{0-9}|Equal|Comma|Period|Slash|Quote|Backquote|Backslash|Minus|Semicolon|Space$/); + return !!event.code.match(/[Key{A-Z}Digit{0-9}EqualCommaPeriodSlashQuoteBackquoteBackslashMinusSemicolonSpaceEnter]/); } From 7dc275c4a30027a219a1a8132b876a9c54028179 Mon Sep 17 00:00:00 2001 From: meganrogge Date: Fri, 3 Nov 2023 14:41:29 -0700 Subject: [PATCH 2/3] fix regex --- .../workbench/contrib/accessibility/browser/accessibleView.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/accessibility/browser/accessibleView.ts b/src/vs/workbench/contrib/accessibility/browser/accessibleView.ts index 7fcca360f35..d55cddee843 100644 --- a/src/vs/workbench/contrib/accessibility/browser/accessibleView.ts +++ b/src/vs/workbench/contrib/accessibility/browser/accessibleView.ts @@ -778,5 +778,5 @@ function shouldHide(event: KeyboardEvent, keybindingService: IKeybindingService) } function shouldHandleKey(event: KeyboardEvent): boolean { - return !!event.code.match(/[Key{A-Z}Digit{0-9}EqualCommaPeriodSlashQuoteBackquoteBackslashMinusSemicolonSpaceEnter]/); + return !!event.code.match(/(Key[A-Z]|Digit[0-9]|Equal|Comma|Period|Slash|Quote|Backquote|Backslash|Minus|Semicolon|Space|Enter)/); } From 17e332e5c31892e764b7a16bd23976fe424b90c9 Mon Sep 17 00:00:00 2001 From: meganrogge Date: Fri, 3 Nov 2023 14:43:37 -0700 Subject: [PATCH 3/3] add start and end --- .../workbench/contrib/accessibility/browser/accessibleView.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/accessibility/browser/accessibleView.ts b/src/vs/workbench/contrib/accessibility/browser/accessibleView.ts index d55cddee843..b348ffd8111 100644 --- a/src/vs/workbench/contrib/accessibility/browser/accessibleView.ts +++ b/src/vs/workbench/contrib/accessibility/browser/accessibleView.ts @@ -778,5 +778,5 @@ function shouldHide(event: KeyboardEvent, keybindingService: IKeybindingService) } function shouldHandleKey(event: KeyboardEvent): boolean { - return !!event.code.match(/(Key[A-Z]|Digit[0-9]|Equal|Comma|Period|Slash|Quote|Backquote|Backslash|Minus|Semicolon|Space|Enter)/); + return !!event.code.match(/^(Key[A-Z]|Digit[0-9]|Equal|Comma|Period|Slash|Quote|Backquote|Backslash|Minus|Semicolon|Space|Enter)$/); }