diff --git a/extensions/html-language-features/server/src/modes/javascriptMode.ts b/extensions/html-language-features/server/src/modes/javascriptMode.ts index 191253d0d2c..0c124f2d468 100644 --- a/extensions/html-language-features/server/src/modes/javascriptMode.ts +++ b/extensions/html-language-features/server/src/modes/javascriptMode.ts @@ -131,7 +131,7 @@ export function getJavaScriptMode(documentRegions: LanguageModelCache { let span = info.span; diff --git a/extensions/typescript-language-features/src/typescriptService.ts b/extensions/typescript-language-features/src/typescriptService.ts index 67be9e314c0..729bda6af6c 100644 --- a/extensions/typescript-language-features/src/typescriptService.ts +++ b/extensions/typescript-language-features/src/typescriptService.ts @@ -11,11 +11,6 @@ import { TypeScriptServiceConfiguration } from './utils/configuration'; import Logger from './utils/logger'; import BufferSyncSupport from './features/bufferSyncSupport'; -declare module './protocol' { - export type JsxClosingTagRequestArgs = any; - export type JsxClosingTagResponse = any; -} - export interface ITypeScriptServiceClient { /** * Convert a resource (VS Code) to a normalized path (TypeScript). diff --git a/extensions/typescript-language-features/src/utils/previewer.ts b/extensions/typescript-language-features/src/utils/previewer.ts index ce10fcbbe04..41ff1fea7d6 100644 --- a/extensions/typescript-language-features/src/utils/previewer.ts +++ b/extensions/typescript-language-features/src/utils/previewer.ts @@ -72,13 +72,18 @@ export function markdownDocumentation( export function addMarkdownDocumentation( out: MarkdownString, - documentation: Proto.SymbolDisplayPart[], - tags: Proto.JSDocTagInfo[] + documentation: Proto.SymbolDisplayPart[] | undefined, + tags: Proto.JSDocTagInfo[] | undefined ): MarkdownString { - out.appendMarkdown(plain(documentation)); - const tagsPreview = tagsMarkdownPreview(tags); - if (tagsPreview) { - out.appendMarkdown('\n\n' + tagsPreview); + if (documentation) { + out.appendMarkdown(plain(documentation)); + } + + if (tags) { + const tagsPreview = tagsMarkdownPreview(tags); + if (tagsPreview) { + out.appendMarkdown('\n\n' + tagsPreview); + } } return out; } diff --git a/extensions/yarn.lock b/extensions/yarn.lock index 7ec0734b094..64d1bf83d0f 100644 --- a/extensions/yarn.lock +++ b/extensions/yarn.lock @@ -2,6 +2,6 @@ # yarn lockfile v1 -typescript@2.9.2: - version "2.9.2" - resolved "https://registry.yarnpkg.com/typescript/-/typescript-2.9.2.tgz#1cbf61d05d6b96269244eb6a3bce4bd914e0f00c" +typescript@3.0.0-insiders.20180706: + version "3.0.0-insiders.20180706" + resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.0.0-insiders.20180706.tgz#684c6c8ca1eefb11e79b6c072a92046ffd75184e"