From 3efab8683c3094787dfa9f61ba44c0787ec06a97 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Sat, 14 Jun 2025 09:08:57 -0700 Subject: [PATCH] Fix terminal icon picker issues Fixes #251428 --- .../contrib/terminal/browser/terminalIconPicker.ts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/vs/workbench/contrib/terminal/browser/terminalIconPicker.ts b/src/vs/workbench/contrib/terminal/browser/terminalIconPicker.ts index f5f78bd178f..57bd2c38c9f 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalIconPicker.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalIconPicker.ts @@ -45,8 +45,7 @@ export class TerminalIconPicker extends Disposable { this._iconSelectBox = instantiationService.createInstance(WorkbenchIconSelectBox, { icons: icons.value, - inputBoxStyles: defaultInputBoxStyles, - showIconInfo: true + inputBoxStyles: defaultInputBoxStyles }); } @@ -58,18 +57,21 @@ export class TerminalIconPicker extends Disposable { this._iconSelectBox.dispose(); })); this._iconSelectBox.clearInput(); + const body = getActiveDocument().body; + const bodyRect = body.getBoundingClientRect(); const hoverWidget = this._hoverService.showInstantHover({ content: this._iconSelectBox.domNode, - target: getActiveDocument().body, + target: { + targetElements: [body], + x: bodyRect.left + (bodyRect.width - dimension.width) / 2, + y: bodyRect.top + }, position: { hoverPosition: HoverPosition.BELOW, }, persistence: { sticky: true, }, - appearance: { - showPointer: true - } }, true); if (hoverWidget) { this._register(hoverWidget);