Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 02:28:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

Code review feedback

Browse Source
This commit is contained in:
Gabriel DeBacker
2019-01-26 11:55:40 -08:00
parent cb511b2d91
commit 3f66432eb2
5 changed files with 23 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/vs/workbench/api/node/extHostTerminalService.ts
View File

@@ -372,12 +372,6 @@ export class ExtHostTerminalService implements ExtHostTerminalServiceShape {
}
public $acceptTerminalOpened(id: number, name: string, isRendererOnly: boolean, cols: number, rows: number): void {
// If this is a terminal created by one of the public createTerminal* APIs
// then @acceptTerminalOpened was called from the main thread task
// to indicate that the terminal is ready for use.
// In those cases, we don't need to create the extension host objects
// as they already exist, but, we do still need to fire the events
// to our consumers.
const index = this._getTerminalObjectIndexById(this._terminals, id);
if (index !== null) {
this._onDidOpenTerminal.fire(this.terminals[index]);
@@ -389,6 +383,12 @@ export class ExtHostTerminalService implements ExtHostTerminalServiceShape {
this._onDidOpenTerminalRenderer.fire(renderer);
}
// If this is a terminal created by one of the public createTerminal* APIs
// then @acceptTerminalOpened was called from the main thread task
// to indicate that the terminal is ready for use.
// In those cases, we don't need to create the extension host objects
// as they already exist, but, we do still need to fire the events
// to our consumers.
if ((renderer !== null) && (index !== null)) {
return;
}

2
src/vs/workbench/api/node/extHostTypes.ts
View File

@@ -1636,8 +1636,6 @@ export class ExtensionCallbackExecution implements vscode.ExtensionCallbackExecu
public computeId(): string {
const hash = crypto.createHash('md5');
hash.update('extensionCallback');
// TODO: How is this ID used. Not sure how to create a valid ID from a function.
// TODO: Also not clear on how the ID is used
hash.update(generateUuid());
return hash.digest('hex');
}