Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-03 15:01:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

Don't show help text when filing against an extension, fixes #46787

Browse Source
This commit is contained in:
Rachel Macfarlane
2018-03-28 10:52:47 -07:00
parent 8a63519099
commit 3fca70781e
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/vs/code/electron-browser/issue/issueReporterMain.ts
View File

@@ -624,6 +624,7 @@ export class IssueReporter extends Disposable {
const settingsSearchResultsBlock = document.querySelector('.block-settingsSearchResults');
const problemSource = document.getElementById('problem-source');
const problemSourceHelpText = document.getElementById('problem-source-help-text');
const descriptionTitle = document.getElementById('issue-description-label');
const descriptionSubtitle = document.getElementById('issue-description-subtitle');
const extensionSelector = document.getElementById('extension-selection');
@@ -637,6 +638,8 @@ export class IssueReporter extends Disposable {
hide(searchedExtensionsBlock);
hide(settingsSearchResultsBlock);
hide(problemSource);
hide(problemSourceHelpText);
hide(extensionSelector);
if (issueType === IssueType.Bug) {
show(blockContainer);
@@ -644,11 +647,10 @@ export class IssueReporter extends Disposable {
show(problemSource);
if (fileOnExtension) {
hide(extensionsBlock);
show(extensionSelector);
} else {
show(extensionsBlock);
hide(extensionSelector);
show(problemSourceHelpText);
}
descriptionTitle.innerHTML = `${localize('stepsToReproduce', "Steps to Reproduce")} <span class="required-input">*</span>`;
@@ -662,11 +664,10 @@ export class IssueReporter extends Disposable {
show(problemSource);
if (fileOnExtension) {
hide(extensionsBlock);
show(extensionSelector);
} else {
show(extensionsBlock);
hide(extensionSelector);
show(problemSourceHelpText);
}
descriptionTitle.innerHTML = `${localize('stepsToReproduce', "Steps to Reproduce")} <span class="required-input">*</span>`;

2
src/vs/code/electron-browser/issue/issueReporterPage.ts
View File

@@ -25,7 +25,7 @@ export default (): string => `
<option value="false">${escape(localize('vscode', "Visual Studio Code"))}</option>
<option value="true">${escape(localize('extension', "An Extension"))}</option>
</select>
<div class="instructions">${escape(localize('disableExtensionsLabelText', "Try to reproduce the problem after {0}. If the problem only reproduces when extensions are active, it is likely an issue with an extension."))
<div id="problem-source-help-text" class="instructions">${escape(localize('disableExtensionsLabelText', "Try to reproduce the problem after {0}. If the problem only reproduces when extensions are active, it is likely an issue with an extension."))
.replace('{0}', `<span tabIndex=0 role="button" id="disableExtensions" class="workbenchCommand">${escape(localize('disableExtensions', "disabling all extensions and reloading the window"))}</span>`)}
</div>