From 3fcf9d7eae7d85500f1213b1043fef5b3c6fab97 Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Thu, 26 Sep 2019 11:01:24 +0200 Subject: [PATCH] remove casting bufferlogservice --- src/vs/platform/log/common/bufferLog.ts | 28 ++++++++++++------------- src/vs/workbench/browser/web.main.ts | 4 ++-- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/vs/platform/log/common/bufferLog.ts b/src/vs/platform/log/common/bufferLog.ts index bdf382bd1e1..32a1f521891 100644 --- a/src/vs/platform/log/common/bufferLog.ts +++ b/src/vs/platform/log/common/bufferLog.ts @@ -7,7 +7,7 @@ import { ILogService, LogLevel, AbstractLogService, DEFAULT_LOG_LEVEL } from 'vs interface ILog { level: LogLevel; - args: IArguments; + args: any[]; } function getLogFunction(logger: ILogService, level: LogLevel): Function { @@ -49,7 +49,7 @@ export class BufferLogService extends AbstractLogService implements ILogService this.buffer = []; } - private _log(level: LogLevel, args: IArguments): void { + private _log(level: LogLevel, ...args: any[]): void { if (this._logger) { const fn = getLogFunction(this._logger, level); fn.apply(this._logger, args); @@ -58,28 +58,28 @@ export class BufferLogService extends AbstractLogService implements ILogService } } - trace(): void { - this._log(LogLevel.Trace, arguments); + trace(message: string, ...args: any[]): void { + this._log(LogLevel.Trace, message, ...args); } - debug(): void { - this._log(LogLevel.Debug, arguments); + debug(message: string, ...args: any[]): void { + this._log(LogLevel.Debug, message, ...args); } - info(): void { - this._log(LogLevel.Info, arguments); + info(message: string, ...args: any[]): void { + this._log(LogLevel.Info, message, ...args); } - warn(): void { - this._log(LogLevel.Warning, arguments); + warn(message: string, ...args: any[]): void { + this._log(LogLevel.Warning, message, ...args); } - error(): void { - this._log(LogLevel.Error, arguments); + error(message: string | Error, ...args: any[]): void { + this._log(LogLevel.Error, message, ...args); } - critical(): void { - this._log(LogLevel.Critical, arguments); + critical(message: string | Error, ...args: any[]): void { + this._log(LogLevel.Critical, message, ...args); } dispose(): void { diff --git a/src/vs/workbench/browser/web.main.ts b/src/vs/workbench/browser/web.main.ts index 9b9097e5015..bad3b51b81f 100644 --- a/src/vs/workbench/browser/web.main.ts +++ b/src/vs/workbench/browser/web.main.ts @@ -216,8 +216,8 @@ class BrowserMain extends Disposable { fileService.registerProvider(logsPath.scheme, indexedDBLogProvider); } catch (error) { - (logService).info('Error while creating indexedDB log provider. Falling back to in-memory log provider.'); - (logService).error(error); + logService.info('Error while creating indexedDB log provider. Falling back to in-memory log provider.'); + logService.error(error); fileService.registerProvider(logsPath.scheme, new InMemoryLogProvider(logsPath.scheme)); }