Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 10:08:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

enforce that extension uses locally unique identifier, https://github.com/microsoft/vscode/issues/129037

Browse Source
This commit is contained in:
Johannes Rieken
2021-09-01 16:49:59 +02:00
parent 00de9bb8ae
commit 4015f350bf
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/vs/workbench/api/common/extHostLanguages.ts
View File

@@ -72,11 +72,20 @@ export class ExtHostLanguages implements ExtHostLanguagesShape {
}
private _handlePool: number = 0;
private _ids = new Set<string>();
createLanguageStatusItem(extension: IExtensionDescription, id: string, selector: vscode.DocumentSelector): vscode.LanguageStatusItem {
const handle = this._handlePool++;
const proxy = this._proxy;
const ids = this._ids;
// enforce extension unique identifier
const fullyQualifiedId = `${extension.identifier.value}/${id}`;
if (ids.has(fullyQualifiedId)) {
throw new Error(`LanguageStatusItem with id '${id}' ALREADY exists`);
}
ids.add(fullyQualifiedId);
const data: Omit<vscode.LanguageStatusItem, 'dispose'> = {
selector,
@@ -92,11 +101,9 @@ export class ExtHostLanguages implements ExtHostLanguagesShape {
const updateAsync = () => {
soonHandle?.dispose();
soonHandle = disposableTimeout(() => {
commandDisposables.clear();
this._proxy.$setLanguageStatus(handle, {
id: `${extension.identifier.value}/${id}`,
id: fullyQualifiedId,
name: data.name ?? extension.displayName ?? extension.name,
source: extension.displayName ?? extension.name,
selector: data.selector,
@@ -114,6 +121,7 @@ export class ExtHostLanguages implements ExtHostLanguagesShape {
commandDisposables.dispose();
soonHandle?.dispose();
proxy.$removeLanguageStatus(handle);
ids.delete(fullyQualifiedId);
},
get id() {
return data.id;